Skip to content

Fix proc test data paths #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyamalpani merged 2 commits into from
Mar 11, 2025
+24 −22
Merged

Fix proc test data paths #603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc1c77
fix paths to proc test data
shreyamalpani Mar 11, 2025
5b514d6
cargo fmt
shreyamalpani Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions bottlecap/src/proc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,19 +365,19 @@ mod tests {
assert!((network_data.tx_bytes - 254.0).abs() < f64::EPSILON);

let path = "./tests/proc/net/invalid_dev_malformed";
let network_data_result = get_network_data_from_path(path);
let network_data_result = get_network_data_from_path(path_from_root(path).as_str());
assert!(network_data_result.is_err());

let path = "./tests/proc/net/invalid_dev_non_numerical_value";
let network_data_result = get_network_data_from_path(path);
let network_data_result = get_network_data_from_path(path_from_root(path).as_str());
assert!(network_data_result.is_err());

let path = "./tests/proc/net/missing_interface_dev";
let network_data_result = get_network_data_from_path(path);
let network_data_result = get_network_data_from_path(path_from_root(path).as_str());
assert!(network_data_result.is_err());

let path = "./tests/proc/net/nonexistent_dev";
let network_data_result = get_network_data_from_path(path);
let network_data_result = get_network_data_from_path(path_from_root(path).as_str());
assert!(network_data_result.is_err());
}

Expand Down Expand Up @@ -411,27 +411,27 @@ mod tests {
);

let path = "./tests/proc/stat/invalid_stat_non_numerical_value_1";
let cpu_data_result = get_cpu_data_from_path(path);
let cpu_data_result = get_cpu_data_from_path(path_from_root(path).as_str());
assert!(cpu_data_result.is_err());

let path = "./tests/proc/stat/invalid_stat_non_numerical_value_2";
let cpu_data_result = get_cpu_data_from_path(path);
let cpu_data_result = get_cpu_data_from_path(path_from_root(path).as_str());
assert!(cpu_data_result.is_err());

let path = "./tests/proc/stat/invalid_stat_malformed_first_line";
let cpu_data_result = get_cpu_data_from_path(path);
let cpu_data_result = get_cpu_data_from_path(path_from_root(path).as_str());
assert!(cpu_data_result.is_err());

let path = "./tests/proc/stat/invalid_stat_malformed_per_cpu_line";
let cpu_data_result = get_cpu_data_from_path(path);
let cpu_data_result = get_cpu_data_from_path(path_from_root(path).as_str());
assert!(cpu_data_result.is_err());

let path = "./tests/proc/stat/invalid_stat_missing_cpun_data";
let cpu_data_result = get_cpu_data_from_path(path);
let cpu_data_result = get_cpu_data_from_path(path_from_root(path).as_str());
assert!(cpu_data_result.is_err());

let path = "./tests/proc/stat/nonexistent_stat";
let cpu_data_result = get_cpu_data_from_path(path);
let cpu_data_result = get_cpu_data_from_path(path_from_root(path).as_str());
assert!(cpu_data_result.is_err());
}

Expand All @@ -444,32 +444,32 @@ mod tests {
assert!((uptime_data - 3_213_103_123_000.0).abs() < f64::EPSILON);

let path = "./tests/proc/uptime/invalid_data_uptime";
let uptime_data_result = get_uptime_from_path(path);
let uptime_data_result = get_uptime_from_path(path_from_root(path).as_str());
assert!(uptime_data_result.is_err());

let path = "./tests/proc/uptime/malformed_uptime";
let uptime_data_result = get_uptime_from_path(path);
let uptime_data_result = get_uptime_from_path(path_from_root(path).as_str());
assert!(uptime_data_result.is_err());

let path = "./tests/proc/uptime/nonexistent_uptime";
let uptime_data_result = get_uptime_from_path(path);
let uptime_data_result = get_uptime_from_path(path_from_root(path).as_str());
assert!(uptime_data_result.is_err());
}

#[test]
fn test_get_fd_max_data() {
let path = "./tests/proc/process/valid";
let pids = get_pid_list_from_path(path_from_root(path).as_str());
let fd_max = get_fd_max_data_from_path(path, &pids);
let fd_max = get_fd_max_data_from_path(path_from_root(path).as_str(), &pids);
assert!((fd_max - 900.0).abs() < f64::EPSILON);

let path = "./tests/proc/process/invalid_malformed";
let fd_max = get_fd_max_data_from_path(path, &pids);
let fd_max = get_fd_max_data_from_path(path_from_root(path).as_str(), &pids);
// assert that fd_max is equal to AWS Lambda limit
assert!((fd_max - constants::LAMBDA_FILE_DESCRIPTORS_DEFAULT_LIMIT).abs() < f64::EPSILON);

let path = "./tests/proc/process/invalid_missing";
let fd_max = get_fd_max_data_from_path(path, &pids);
let fd_max = get_fd_max_data_from_path(path_from_root(path).as_str(), &pids);
// assert that fd_max is equal to AWS Lambda limit
assert!((fd_max - constants::LAMBDA_FILE_DESCRIPTORS_DEFAULT_LIMIT).abs() < f64::EPSILON);
}
Expand All @@ -478,27 +478,27 @@ mod tests {
fn test_get_fd_use_data() {
let path = "./tests/proc/process/valid";
let pids = get_pid_list_from_path(path_from_root(path).as_str());
let fd_use = get_fd_use_data_from_path(path, &pids);
let fd_use = get_fd_use_data_from_path(path_from_root(path).as_str(), &pids);
assert!((fd_use - 5.0).abs() < f64::EPSILON);
}

#[test]
fn test_get_threads_max_data() {
let path = "./tests/proc/process/valid";
let pids = get_pid_list_from_path(path_from_root(path).as_str());
let threads_max = get_threads_max_data_from_path(path, &pids);
let threads_max = get_threads_max_data_from_path(path_from_root(path).as_str(), &pids);
assert!((threads_max - 1024.0).abs() < f64::EPSILON);

let path = "./tests/proc/process/invalid_malformed";
let threads_max = get_threads_max_data_from_path(path, &pids);
let threads_max = get_threads_max_data_from_path(path_from_root(path).as_str(), &pids);
// assert that threads_max is equal to AWS Lambda limit
assert!(
(threads_max - constants::LAMBDA_EXECUTION_PROCESSES_DEFAULT_LIMIT).abs()
< f64::EPSILON
);

let path = "./tests/proc/process/invalid_missing";
let threads_max = get_threads_max_data_from_path(path, &pids);
let threads_max = get_threads_max_data_from_path(path_from_root(path).as_str(), &pids);
// assert that threads_max is equal to AWS Lambda limit
assert!(
(threads_max - constants::LAMBDA_EXECUTION_PROCESSES_DEFAULT_LIMIT).abs()
Expand All @@ -510,13 +510,15 @@ mod tests {
fn test_get_threads_use_data() {
let path = "./tests/proc/process/valid";
let pids = get_pid_list_from_path(path_from_root(path).as_str());
let threads_use_result = get_threads_use_data_from_path(path, &pids);
let threads_use_result =
get_threads_use_data_from_path(path_from_root(path).as_str(), &pids);
assert!(threads_use_result.is_ok());
let threads_use = threads_use_result.unwrap();
assert!((threads_use - 5.0).abs() < f64::EPSILON);

let path = "./tests/proc/process/invalid_missing";
let threads_use_result = get_threads_use_data_from_path(path, &pids);
let threads_use_result =
get_threads_use_data_from_path(path_from_root(path).as_str(), &pids);
assert!(threads_use_result.is_err());
}
}