Conversation
duncanista
reviewed
Mar 13, 2025
duncanista
approved these changes
Mar 13, 2025
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
LGTM – wondering if we should merge the log that says "vXX version of the Datadog Extension", we can just add version and time it started in the same one, me thinks
Contributor
Author
|
I don't think so, because a lot can go wrong between when that log is emitted and we're done booting – I want to make sure we get the version number even if we fail to start, or fail over, for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a debug message with our init duration for the extension specifically, measured by the time main begins to the time we call
/nextaids in debugging/disambiguation cases