Skip to content

aj/support log tags#610

Merged
astuyve merged 5 commits intomainfrom
aj/support-log-tags
Mar 17, 2025
Merged

aj/support log tags#610
astuyve merged 5 commits intomainfrom
aj/support-log-tags

Conversation

@astuyve
Copy link
Copy Markdown
Contributor

@astuyve astuyve commented Mar 13, 2025

Fixes #515

You can reproduce by creating a new lambda function, enabling JSON logs in Lambda, and then logging something like this:

  console.log({ddtags: 'aj:test,aj_type:added_tags', message: {input: event, more_items: "are working"}});

You should be able to search for those tags in the app:
image

@astuyve astuyve requested a review from a team as a code owner March 13, 2025 20:32
Copy link
Copy Markdown
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I'd like to see the performance implications of trying to parse every message into a json object, I'd expect serde to do a great job here already tho

@astuyve astuyve merged commit 0e8d7bf into main Mar 17, 2025
33 checks passed
@astuyve astuyve deleted the aj/support-log-tags branch March 17, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ddtags is not honored in v68 of Next Generation version

2 participants