Skip to content

do not exit the loop if no context is found#616

Merged
alexgallotta merged 1 commit intomainfrom
fix-first-tracer-propagation-
Mar 18, 2025
Merged

do not exit the loop if no context is found#616
alexgallotta merged 1 commit intomainfrom
fix-first-tracer-propagation-

Conversation

@alexgallotta
Copy link
Copy Markdown
Contributor

@alexgallotta alexgallotta commented Mar 18, 2025 •
edited by duncanista
Loading

What?

Fixes a bug where Span Context was return even if it was None when trace_propagator_extract_first was enabled

@alexgallotta alexgallotta requested a review from a team as a code owner March 18, 2025 19:07
duncanista
duncanista approved these changes Mar 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@duncanista duncanista left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description and clear title to this PR – LGTM

@alexgallotta alexgallotta merged commit d365eba into main Mar 18, 2025
33 checks passed
@alexgallotta alexgallotta deleted the fix-first-tracer-propagation- branch March 18, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncanista duncanista duncanista approved these changes

@astuyve astuyve Awaiting requested review from astuyve

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexgallotta @duncanista