[dotnet] don't override env vars if set by user#623
Merged
lucaspimentel merged 4 commits intomainfrom Mar 26, 2025
Merged
Conversation
duncanista
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the way we set .NET environment variables in
datadog_wrapper, so we only set them if they are not already set. This prevents the script from overriding env vars set by the user.For example, setting
CORECLR_ENABLE_PROFILING=0does not disable the tracer, becausedatadog_wrapperthen setsCORECLR_ENABLE_PROFILING=1. See DataDog/dd-trace-dotnet-aws-lambda-layer#14.