chore: remove mutex lock for ContextBuffer #630
Merged
duncanista merged 4 commits intomainfrom Mar 31, 2025
Merged
Conversation
replaces sharing the `ContextBuffer`, now we directly access the `InvocationProcessor` to add the tracer top level span
alexgallotta
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the Mutex Lock on
ContextBufferMotivation
We were using
ContextBufferto sharetracer_spanso that we can enrich the top level span generated by the Extension. Instead, we now share the already existingInvocationProcessorlock which allows us to set thetracer_spanon the given context.Tests
Works as before.
Notes
There is a known issue which only makes it work on cold start spans, this was also something that appeared on the previous approach.