Skip to content

chore(github): separate vulnerability scans#739

Merged
duncanista merged 6 commits into
mainfrom
jordan.gonzalez/github/separate-vulnerability-scans
Jul 14, 2025
Merged

chore(github): separate vulnerability scans#739
duncanista merged 6 commits into
mainfrom
jordan.gonzalez/github/separate-vulnerability-scans

Conversation

@duncanista
Copy link
Copy Markdown
Contributor

@duncanista duncanista commented Jul 11, 2025

What?

Separates Lambda Extension and Serverless Init vulnerability scans

Motivation

If Serverless Init fails, Lambda doesnt execute, here it justs separates them and runs them per scanner and per product

Tests

Screenshot 2025-07-11 at 11 38 07 AM

@duncanista duncanista requested a review from a team as a code owner July 11, 2025 18:32
Comment thread .github/workflows/vulnerability-scan.yml Outdated
Comment thread .github/workflows/serverless-init-vulnerability-scan.yml Outdated
Comment thread .github/workflows/serverless-init-vulnerability-scan.yml
Copy link
Copy Markdown
Contributor

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a world where we can run the vulnerability workflow for a matrix of images and have them fail independently with jobs.<job_id>.strategy.fail-fast -> false. But this would just be an optimization of the current approach rather than actually changing the end result of what's scanned.

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

@duncanista duncanista force-pushed the jordan.gonzalez/github/separate-vulnerability-scans branch from b99ee42 to edd9c3a Compare July 14, 2025 19:00
@duncanista duncanista merged commit 2816ae4 into main Jul 14, 2025
46 checks passed
@duncanista duncanista deleted the jordan.gonzalez/github/separate-vulnerability-scans branch July 14, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants