[SVLS-8179] add debug log for flush strategy#974
Merged
jchrostek-dd merged 1 commit intomainfrom Dec 31, 2025
Merged
Conversation
lym953
approved these changes
Dec 31, 2025
Comment on lines
+91
to
+96
|
|
||
| // Log all non-Extension telemetry events to avoid infinite loop | ||
| if !matches!(event.record, TelemetryRecord::Extension(_)) { | ||
| debug!("LOGS | Incoming telemetry event: {:?}", event.record); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
We are already logging telemetry events here:
Is the new log added to help debug what happens in between?
Contributor
Author
There was a problem hiding this comment.
Yeah, helpful for what happens in between. When I was looking at logs for Durable Functions, it seemed like we were missing some things.
Contributor
There was a problem hiding this comment.
We should probably revert this. If we’re missing something for durable functions then let’s find out why it’s not being captured and sent to Datadog or via a Datadog flare. This will cause us to double log everything the user sends if debug logs are enabled, which will more than 2x the cost for no value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Testing