Skip to content

Commit 655f5f2

Browse files
authored
ci: drop redundant NodeGYP install step (#789)
The unit-test matrix had a step that ran `yarn global add node-gyp` for Node 20.19, 22.11, and 24.11. This started failing on every PR and on main once node-gyp@13 released, because node-gyp@13 pulls proc-log@7.0.0, which declares engines as ^22.22.2 || ^24.15.0 || >=26.0.0 -- rejecting every Node version in our matrix. Rather than pin around the upstream churn, drop the step. node-gyp is only needed as a fallback to compile native addons at install time, and the modern npm bundled with Node 20+ already ships its own node-gyp for that purpose. The 18.12 matrix entry has never run this step and installs cleanly, which is evidence the global install was already redundant. If a future native dependency genuinely needs node-gyp on a specific Node version, we can reintroduce it with an explicit pin scoped to that need.
1 parent 58c6e76 commit 655f5f2

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

.github/workflows/build.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@ jobs:
6666
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
6767
restore-keys: |
6868
${{ runner.os }}-yarn-
69-
- name: Install NodeGYP
70-
if: matrix.node-version == '20.19' || matrix.node-version == '22.11' || matrix.node-version == '24.11'
71-
run: yarn global add node-gyp
72-
7369
- name: Install dependencies
7470
run: yarn install
7571

0 commit comments

Comments
 (0)