Skip to content

Change ADP default health port to 5400#3014

Open
webern wants to merge 1 commit into
mainfrom
matt.briggs/adp-health-port-5400
Open

Change ADP default health port to 5400#3014
webern wants to merge 1 commit into
mainfrom
matt.briggs/adp-health-port-5400

Conversation

@webern
Copy link
Copy Markdown

@webern webern commented May 14, 2026

What does this PR do?

Set DD_DATA_PLANE_API_LISTEN_ADDRESS explicitly on the ADP container so the operator controls the listen port, keeping probes in sync regardless of ADP's compiled-in default.

Motivation

We needed to change ADP's default listen port to avoid potential conflicts with existing Agent installs.

Ref: DataDog/saluki#1652

Minimum Agent Versions

N/A

Describe your test plan

I believe the e2e testing is sufficient. In particular, test/e2e/manifests/dogstatsd/datadog-agent-dsd-udp-adp.yaml

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

Set DD_DATA_PLANE_API_LISTEN_ADDRESS explicitly on the ADP
container so the operator controls the listen port, keeping
probes in sync regardless of ADP's compiled-in default.

Ref: DataDog/saluki#1652
@webern webern added this to the v1.27.0 milestone May 14, 2026
@webern webern requested a review from a team May 14, 2026 14:32
@webern webern requested a review from a team as a code owner May 14, 2026 14:33
@webern webern added the enhancement New feature or request label May 14, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.91%. Comparing base (7f86fa0) to head (b61c5bf).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3014   +/-   ##
=======================================
  Coverage   40.90%   40.91%           
=======================================
  Files         333      333           
  Lines       28327    28331    +4     
=======================================
+ Hits        11588    11592    +4     
  Misses      15960    15960           
  Partials      779      779           
Flag Coverage Δ
unittests 40.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntroller/datadogagent/feature/dataplane/feature.go 82.14% <100.00%> (+1.37%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f86fa0...b61c5bf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-prod-us1-4

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants