Revert "feat: Add APM to DatadogInstrumentation CRD (#2984)"#3015
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e36ea5833b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3015 +/- ##
=======================================
Coverage 40.90% 40.90%
=======================================
Files 333 333
Lines 28327 28327
=======================================
Hits 11588 11588
Misses 15960 15960
Partials 779 779
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
e36ea58 to
1f59178
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.27 v1.27
# Navigate to the new working tree
cd .worktrees/backport-v1.27
# Create a new branch
git switch --create backport-3015-to-v1.27
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6d3740ad41bd664fc11024784672c48f6174e82f
# Push it to GitHub
git push --set-upstream origin backport-3015-to-v1.27
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.27Then, create a pull request where the |
What does this PR do?
Reverts #2984 & #2995
Reverting the APM section in the DDI CRD spec since it'll likely not being used in the next Agent release (7.80)
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel