Operator release v1.27.0-rc.2#3018
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4a22e511c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| enum: | ||
| - running | ||
| - stopped | ||
| - rollback | ||
| - timeout | ||
| - terminated | ||
| - promoted | ||
| - aborted |
There was a problem hiding this comment.
Keep legacy experiment phase enum values during upgrade
Do not remove previously served enum values from status.experiment.phase in the bundled CRD without a migration path. This change drops stopped, rollback, and timeout, so clusters upgrading from versions that may already persist those statuses can hit validation failures on subsequent updates (especially on Kubernetes versions without CRD validation ratcheting), because existing objects no longer conform to the new schema. Keeping legacy values accepted (and mapping them in-controller) avoids breaking in-place upgrades.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.27 #3018 +/- ##
=======================================
Coverage 41.36% 41.36%
=======================================
Files 334 334
Lines 28586 28586
=======================================
Hits 11826 11826
Misses 15970 15970
Partials 790 790
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel