PoC constructor coverage refactor#3021
Draft
tbavelier wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## tbavelier/improve-coverage-quick-wins #3021 +/- ##
=========================================================================
- Coverage 47.72% 47.71% -0.02%
=========================================================================
Files 331 332 +1
Lines 28322 28145 -177
=========================================================================
- Hits 13518 13430 -88
+ Misses 13976 13887 -89
Partials 828 828
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
🎯 Code Coverage (details) 🔗 Commit SHA: 38af679 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PoC refactor for static constructors: move probe and RBAC literals into templates and return copied values.
Motivation
Improve useful coverage without adding tests that only restate constructor bodies.
Additional Notes
Stacked on #3020. Uses
DeepCopy()for Kubernetes probes andslices.Clonefor RBAC rule slices to avoid shared mutable defaults.Minimum Agent Versions
Describe your test plan
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel