false on http expection + tests

Author: ndakkoune

aws/logs_monitoring/settings.py

@@ -274,6 +274,7 @@ def is_api_key_valid():
             f"Could not validate Datadog API key due to a network error: {e}. "
             "Proceeding without validation."
         )
+        return False
 
     return True
 

aws/logs_monitoring/tests/test_settings.py

@@ -0,0 +1,56 @@
+import unittest
+from unittest.mock import MagicMock, patch
+
+import settings as _settings_module
+from settings import is_api_key_valid
+
+VALID_API_KEY = "11111111111111111111111111111111"
+
+class TestIsApiKeyValid(unittest.TestCase):
+    @patch("settings.DD_API_KEY", VALID_API_KEY)
+    @patch("settings.requests.Session")
+    def test_valid_api_key(self, mock_session_cls):
+        mock_response = MagicMock()
+        mock_response.ok = True
+        mock_session_cls.return_value.__enter__.return_value.get.return_value = (
+            mock_response
+        )
+        self.assertTrue(is_api_key_valid())
+
+    @patch("settings.DD_API_KEY", "")
+    def test_empty_api_key(self):
+        with self.assertRaises(Exception):
+            is_api_key_valid()
+
+    @patch("settings.DD_API_KEY", "shortapikey")
+    def test_invalid_api_key_format(self):
+        with self.assertRaises(Exception):
+            is_api_key_valid()
+
+    @patch("settings.DD_API_KEY", VALID_API_KEY)
+    @patch("settings.logger")
+    @patch("settings.requests.Session")
+    def test_on_connection_exception(self, mock_session_cls, mock_logger):
+        mock_session_cls.return_value.__enter__.return_value.get.side_effect = (
+            _settings_module.requests.exceptions.ConnectionError
+        )
+        result = is_api_key_valid()
+        self.assertFalse(result)
+        mock_logger.warning.assert_called_once()
+        self.assertIn("network error", mock_logger.warning.call_args[0][0].lower())
+
+    @patch("settings.DD_API_KEY", VALID_API_KEY)
+    @patch("settings.logger")
+    @patch("settings.requests.Session")
+    def test_on_timeout_exception(self, mock_session_cls, mock_logger):
+        mock_session_cls.return_value.__enter__.return_value.get.side_effect = (
+            _settings_module.requests.exceptions.Timeout
+        )
+        result = is_api_key_valid()
+        self.assertFalse(result)
+        mock_logger.warning.assert_called_once()
+        self.assertIn("network error", mock_logger.warning.call_args[0][0].lower())
+
+
+if __name__ == "__main__":
+    unittest.main()