Skip to content

Commit a8ea167

Browse files
authored
Update test_s3_handler.py
Removed added tests, since s3_handler.py is no longer modified.
1 parent d49b441 commit a8ea167

1 file changed

Lines changed: 0 additions & 49 deletions

File tree

aws/logs_monitoring/tests/test_s3_handler.py

Lines changed: 0 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -325,55 +325,6 @@ def test_non_vpc_flowlog_includes_first_line(self):
325325
self.assertEqual(len(structured_lines), 3)
326326
self.assertEqual(structured_lines[0]["message"], "first line of data")
327327

328-
@patch("steps.handlers.s3_handler.boto3")
329-
def test_backward_compatibility_direct_s3(self, mock_boto3):
330-
"""Test that direct S3 events still work after EventBridge changes"""
331-
mock_s3_client = MagicMock()
332-
mock_s3_client.get_object.return_value = {
333-
"Body": MagicMock(read=MagicMock(return_value=b"direct s3 log"))
334-
}
335-
mock_boto3.client.return_value = mock_s3_client
336-
337-
direct_s3_event = {
338-
"Records": [
339-
{
340-
"s3": {
341-
"bucket": {"name": "my-bucket"},
342-
"object": {"key": "my-key"},
343-
}
344-
}
345-
]
346-
}
347-
348-
logs = list(self.s3_handler.handle(direct_s3_event))
349-
350-
self.assertEqual(len(logs), 1)
351-
self.assertEqual(logs[0]["message"], "direct s3 log")
352-
353-
@patch("steps.handlers.s3_handler.boto3")
354-
def test_backward_compatibility_sns_wrapped_s3(self, mock_boto3):
355-
"""Test that SNS-wrapped S3 events still work after EventBridge changes"""
356-
mock_s3_client = MagicMock()
357-
mock_s3_client.get_object.return_value = {
358-
"Body": MagicMock(read=MagicMock(return_value=b"sns wrapped log"))
359-
}
360-
mock_boto3.client.return_value = mock_s3_client
361-
362-
sns_wrapped_event = {
363-
"Records": [
364-
{
365-
"Sns": {
366-
"Message": '{"Records": [{"s3": {"bucket": {"name": "my-bucket"}, "object": {"key": "sns-my-key"}}}]}'
367-
}
368-
}
369-
]
370-
}
371-
372-
logs = list(self.s3_handler.handle(sns_wrapped_event))
373-
374-
self.assertEqual(len(logs), 1)
375-
self.assertEqual(logs[0]["message"], "sns wrapped log")
376-
377328

378329
if __name__ == "__main__":
379330
unittest.main()

0 commit comments

Comments
 (0)