refactor envOrDefaultBool to use strconv.ParseBool

Author: ndakkoune

aws/logs_monitoring_go/internal/config/environment.go

@@ -8,7 +8,7 @@ package config
 import (
 	"log/slog"
 	"os"
-	"strings"
+	"strconv"
 )
 
 var deprecatedEnvironmentVariables = []string{
@@ -43,7 +43,12 @@ func envOrDefaultBool(key string, fallback bool) bool {
 	if !ok {
 		return fallback
 	}
-	return strings.EqualFold(v, "true")
+	b, err := strconv.ParseBool(v)
+	if err != nil {
+		slog.Warn("invalid boolean env var, using default", slog.String("key", key), slog.String("value", v), slog.Bool("default", fallback))
+		return fallback
+	}
+	return b
 }
 
 func logDroppedEnvVars() {

aws/logs_monitoring_go/internal/config/environment_test.go

@@ -46,8 +46,10 @@ func TestEnvOrDefaultBool(t *testing.T) {
 		"true_uppercase":       {value: "TRUE", set: true, fallback: false, want: true},
 		"true_mixed_case":      {value: "True", set: true, fallback: false, want: true},
 		"false_value":          {value: "false", set: true, fallback: true, want: false},
-		"invalid_value":        {value: "yes", set: true, fallback: true, want: false},
-		"empty_value":          {value: "", set: true, fallback: true, want: false},
+		"one_is_true":          {value: "1", set: true, fallback: false, want: true},
+		"zero_is_false":        {value: "0", set: true, fallback: true, want: false},
+		"invalid_uses_fallback": {value: "yes", set: true, fallback: true, want: true},
+		"empty_uses_fallback":  {value: "", set: true, fallback: true, want: true},
 	}
 
 	for name, tc := range tests {