[AWSINTS-3514] feat(go-forwarder): add Kinesis invocation#1110
Merged
ndakkoune merged 4 commits intoApr 21, 2026
Conversation
ndakkoune
changed the title
ge0Aja
reviewed
Apr 21, 2026
ge0Aja
reviewed
Apr 21, 2026
ndakkoune
force-pushed
the
nabil.dakkoune/AWSINTS-3514
branch
from
68bba8d to
9be32d7
Compare
ge0Aja
reviewed
Apr 21, 2026
| } | ||
|
|
||
| for _, record := range kinesisEvent.Records { | ||
| cwEvent := events.CloudwatchLogsEvent{ |
Contributor
There was a problem hiding this comment.
nit: extract this to a function
ge0Aja
approved these changes
Apr 21, 2026
ge0Aja
left a comment
ge0Aja
left a comment
Contributor
There was a problem hiding this comment.
lgtm, added a nit comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the Kinesis handler responsible to wrap and redirect to the CloudWatch parsing logic.
Motivation
Testing Guidelines
Additional Notes
record.Kinesis.Datain base64 because the json.unmarshal give usevents.KinesisRecord.Datawhich are already base64 decoded but not ungzipped. We go this way to leverageHandleCloudwatchLogs.Types of changes
Check all that apply