Skip to content

fix(go-forwarder): sns service not falling back from source#1132

Merged
ndakkoune merged 1 commit into
nabil.dakkoune/go-forwarderfrom
nabil.dakkoune/go-forwarder-no-sns-service
May 22, 2026
Merged

fix(go-forwarder): sns service not falling back from source#1132
ndakkoune merged 1 commit into
nabil.dakkoune/go-forwarderfrom
nabil.dakkoune/go-forwarder-no-sns-service

Conversation

@ndakkoune
Copy link
Copy Markdown
Contributor

What does this PR do?

Makes SNS be source only (not service anymore). Same behavior as Python.

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions Bot added the aws label May 22, 2026
@ndakkoune ndakkoune marked this pull request as ready for review May 22, 2026 08:17
@ndakkoune ndakkoune requested a review from a team as a code owner May 22, 2026 08:17
@ndakkoune ndakkoune requested a review from ge0Aja May 22, 2026 08:17
@ndakkoune ndakkoune merged commit a2bc220 into nabil.dakkoune/go-forwarder May 22, 2026
10 checks passed
@ndakkoune ndakkoune deleted the nabil.dakkoune/go-forwarder-no-sns-service branch May 22, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants