Skip to content

fix(forwader): catch response errors on key verification#1141

Merged
ndakkoune merged 7 commits into
masterfrom
nabil.dakkoune/fix-key-verification-on-http-exceptions
May 29, 2026
Merged

fix(forwader): catch response errors on key verification#1141
ndakkoune merged 7 commits into
masterfrom
nabil.dakkoune/fix-key-verification-on-http-exceptions

Conversation

@ndakkoune
Copy link
Copy Markdown
Contributor

@ndakkoune ndakkoune commented May 29, 2026

What does this PR do?

Prevent http response error to raise an exception and lose log events (when a failed event storage is configured)

Motivation

Testing Guidelines

python -m unittest tests/test_settings.py

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions Bot added the aws label May 29, 2026
@ndakkoune ndakkoune marked this pull request as ready for review May 29, 2026 11:47
@ndakkoune ndakkoune requested a review from a team as a code owner May 29, 2026 11:47
@datadog-datadog-prod-us1-2

This comment has been minimized.

@ndakkoune ndakkoune requested a review from ge0Aja May 29, 2026 12:44
@ndakkoune ndakkoune merged commit e58ad3b into master May 29, 2026
10 checks passed
@ndakkoune ndakkoune deleted the nabil.dakkoune/fix-key-verification-on-http-exceptions branch May 29, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants