fix(go-forwarder): prevent log duplication on SQS event failure#1157
Merged
ndakkoune merged 5 commits intoJun 19, 2026
Conversation
ndakkoune
commented
Jun 18, 2026
Comment on lines
+96
to
+97
| if err := forwarder.Retry(ctx); err != nil { | ||
| return nil, fmt.Errorf("retry: %w", err) |
Contributor
Author
There was a problem hiding this comment.
Since we moved the handler instantiation out of the pipeline, we fast return on retry invocations at the beginning
ge0Aja
reviewed
Jun 19, 2026
ge0Aja
reviewed
Jun 19, 2026
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the potential log duplication we can encounter if an error is raised on a synchronous SQS invocation (see design doc for more information).
Some bouts of this PR are missing and ended up in a previous PR (here and here).