[AWSX] feat(lambda logs forwarder): Allow to opt-out from S3 tags enrichment#946
Merged
Conversation
ViBiOh
reviewed
Jun 13, 2025
|
|
||
| def should_fetch_tags(self): | ||
| return True | ||
| return os.environ.get("DD_FETCH_S3_TAGS", "false").lower() == "true" |
Contributor
There was a problem hiding this comment.
The default is false here but true in the CloudFormation. If we set it to false here, it's a breaking change I think.
Contributor
Author
There was a problem hiding this comment.
it will be false if we don't find it in the env vars, but it should be always set by the template. The behavior here is to not bring in the tags if we don't have the env var set which should be by the template.
Contributor
Author
There was a problem hiding this comment.
However, I'll mark it as a breaking change since it won't be automatic anymore
Contributor
Author
There was a problem hiding this comment.
changed to keep the current behavior
ViBiOh
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to opt out from S3 tags enrichment + re-order fetched tags to have a higher priority for Forwarder set tags, notable
service.If S3 tags enrichment is enabled, the fetched tags will be added infront, which should be deduplicated if the same tags are set as ENV vars on the forwarder's side.
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply