fix: adapt array_has array-needle fast path to arrow 58.3

freakyzoidberg · claude · freakyzoidberg · commit 33f69215a517 · 2026-06-29T13:26:32.000+02:00
BooleanBuffer::has_true() was added in arrow 59; branch-54 is on arrow 58.3, so the element-null per-row reduction uses count_set_bits() &gt; 0 instead. No behavior change (17 array_has unit tests pass, clippy clean).

Co-Authored-By: Claude Opus 4.8 &lt;noreply@anthropic.com&gt;
diff --git a/datafusion/functions-nested/src/array_has.rs b/datafusion/functions-nested/src/array_has.rs
@@ -505,7 +505,8 @@ where
             }
             let start = offsets[i] - first_offset - elem_start;
             let end = offsets[i + 1] - first_offset - elem_start;
-            result.append(matched.slice(start, end - start).has_true());
+            // `BooleanBuffer::has_true()` is arrow >= 59 only; use count_set_bits.
+            result.append(matched.slice(start, end - start).count_set_bits() > 0);
         }
     }
     result.finish()

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,8 @@ where`
`505`	`505`	`}`
`506`	`506`	`let start = offsets[i] - first_offset - elem_start;`
`507`	`507`	`let end = offsets[i + 1] - first_offset - elem_start;`
`508`		`- result.append(matched.slice(start, end - start).has_true());`
	`508`	+ // `BooleanBuffer::has_true()` is arrow >= 59 only; use count_set_bits.
	`509`	`+ result.append(matched.slice(start, end - start).count_set_bits() > 0);`
`509`	`510`	`}`
`510`	`511`	`}`
`511`	`512`	`result.finish()`