Skip to content

Commit 37dc0c4

Browse files
docs: Link missing proto fields to github issue in TODO comment
1 parent 8ce5de3 commit 37dc0c4

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

datafusion/proto/src/logical_plan/from_proto.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,8 @@ pub fn parse_expr(
301301
exec_datafusion_err!("missing window frame during deserialization")
302302
})?;
303303

304-
// TODO: support proto for null treatment
304+
// TODO: support null treatment, distinct, and filter in proto.
305+
// See https://github.com/apache/datafusion/issues/17417
305306
match window_function {
306307
window_expr_node::WindowFunction::Udaf(udaf_name) => {
307308
let udaf_function = match &expr.fun_definition {

datafusion/proto/src/logical_plan/to_proto.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,8 @@ pub fn serialize_expr(
314314
ref partition_by,
315315
ref order_by,
316316
ref window_frame,
317-
// TODO: support null treatment in proto
317+
// TODO: support null treatment, distinct, and filter in proto.
318+
// See https://github.com/apache/datafusion/issues/17417
318319
null_treatment: _,
319320
distinct: _,
320321
filter: _,

0 commit comments

Comments
 (0)