fix: Box WindowFunction in ExprFuncKind enum to reduce enum total size

As suggested by `clippy`:

```
warning: large size difference between variants
   --> datafusion/expr/src/expr_fn.rs:772:1
    |
772 | / pub enum ExprFuncKind {
773 | |     Aggregate(AggregateFunction),
    | |     ---------------------------- the second-largest variant contains at least 72 bytes
774 | |     Window(WindowFunction),
    | |     ---------------------- the largest variant contains at least 288 bytes
775 | | }
    | |_^ the entire enum is at least 288 bytes
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
    = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
    |
774 -     Window(WindowFunction),
774 +     Window(Box<WindowFunction>),
    |
```

Author: geoffreyclaude

datafusion/expr/src/expr_fn.rs

@@ -771,7 +771,7 @@ pub trait ExprFunctionExt {
 #[derive(Debug, Clone)]
 pub enum ExprFuncKind {
     Aggregate(AggregateFunction),
-    Window(WindowFunction),
+    Window(Box<WindowFunction>),
 }
 
 /// Implementation of [`ExprFunctionExt`].
@@ -833,10 +833,11 @@ impl ExprFuncBuilder {
                 udaf.params.null_treatment = null_treatment;
                 Expr::AggregateFunction(udaf)
             }
-            ExprFuncKind::Window(WindowFunction {
-                fun,
-                params: WindowFunctionParams { args, .. },
-            }) => {
+            ExprFuncKind::Window(wf) => {
+                let WindowFunction {
+                    fun,
+                    params: WindowFunctionParams { args, .. },
+                } = *wf;
                 // FILTER is only supported for aggregate window functions
                 if filter.is_some()
                     && matches!(fun, WindowFunctionDefinition::WindowUDF(_))
@@ -912,7 +913,7 @@ impl ExprFunctionExt for Expr {
                 ExprFuncBuilder::new(Some(ExprFuncKind::Aggregate(udaf)))
             }
             Expr::WindowFunction(udwf) => {
-                ExprFuncBuilder::new(Some(ExprFuncKind::Window(*udwf)))
+                ExprFuncBuilder::new(Some(ExprFuncKind::Window(udwf)))
             }
             _ => ExprFuncBuilder::new(None),
         };
@@ -952,7 +953,7 @@ impl ExprFunctionExt for Expr {
                 ExprFuncBuilder::new(Some(ExprFuncKind::Aggregate(udaf)))
             }
             Expr::WindowFunction(udwf) => {
-                ExprFuncBuilder::new(Some(ExprFuncKind::Window(*udwf)))
+                ExprFuncBuilder::new(Some(ExprFuncKind::Window(udwf)))
             }
             _ => ExprFuncBuilder::new(None),
         };
@@ -965,7 +966,7 @@ impl ExprFunctionExt for Expr {
     fn partition_by(self, partition_by: Vec<Expr>) -> ExprFuncBuilder {
         match self {
             Expr::WindowFunction(udwf) => {
-                let mut builder = ExprFuncBuilder::new(Some(ExprFuncKind::Window(*udwf)));
+                let mut builder = ExprFuncBuilder::new(Some(ExprFuncKind::Window(udwf)));
                 builder.partition_by = Some(partition_by);
                 builder
             }
@@ -976,7 +977,7 @@ impl ExprFunctionExt for Expr {
     fn window_frame(self, window_frame: WindowFrame) -> ExprFuncBuilder {
         match self {
             Expr::WindowFunction(udwf) => {
-                let mut builder = ExprFuncBuilder::new(Some(ExprFuncKind::Window(*udwf)));
+                let mut builder = ExprFuncBuilder::new(Some(ExprFuncKind::Window(udwf)));
                 builder.window_frame = Some(window_frame);
                 builder
             }