More clippy errors

Author: LiaCastaneda

datafusion/ffi/src/udwf/partition_evaluator.rs

@@ -86,7 +86,7 @@ pub struct PartitionEvaluatorPrivateData {
 }
 
 impl FFI_PartitionEvaluator {
-    unsafe fn inner_mut(&mut self) -> &mut Box<(dyn PartitionEvaluator + 'static)> {
+    unsafe fn inner_mut(&mut self) -> &mut Box<dyn PartitionEvaluator + 'static> {
         let private_data = self.private_data as *mut PartitionEvaluatorPrivateData;
         &mut (*private_data).evaluator
     }

datafusion/functions-aggregate/src/average.rs

@@ -405,7 +405,7 @@ impl<T: DecimalType + ArrowNumericType + Debug> Accumulator for DecimalAvgAccumu
         self.count += (values.len() - values.null_count()) as u64;
 
         if let Some(x) = sum(values) {
-            let v = self.sum.get_or_insert(T::Native::default());
+            let v = self.sum.get_or_insert_with(T::Native::default);
             self.sum = Some(v.add_wrapping(x));
         }
         Ok(())
@@ -450,7 +450,7 @@ impl<T: DecimalType + ArrowNumericType + Debug> Accumulator for DecimalAvgAccumu
 
         // sums are summed
         if let Some(x) = sum(states[1].as_primitive::<T>()) {
-            let v = self.sum.get_or_insert(T::Native::default());
+            let v = self.sum.get_or_insert_with(T::Native::default);
             self.sum = Some(v.add_wrapping(x));
         }
         Ok(())

datafusion/functions-aggregate/src/bit_and_or_xor.rs

@@ -382,7 +382,7 @@ where
 {
     fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
         if let Some(x) = arrow::compute::bit_or(values[0].as_primitive::<T>()) {
-            let v = self.value.get_or_insert(T::Native::usize_as(0));
+            let v = self.value.get_or_insert_with(|| T::Native::usize_as(0));
             *v = *v | x;
         }
         Ok(())
@@ -427,7 +427,7 @@ where
 {
     fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
         if let Some(x) = arrow::compute::bit_xor(values[0].as_primitive::<T>()) {
-            let v = self.value.get_or_insert(T::Native::usize_as(0));
+            let v = self.value.get_or_insert_with(|| T::Native::usize_as(0));
             *v = *v ^ x;
         }
         Ok(())

datafusion/functions-aggregate/src/sum.rs

@@ -314,7 +314,7 @@ impl<T: ArrowNumericType> Accumulator for SumAccumulator<T> {
     fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
         let values = values[0].as_primitive::<T>();
         if let Some(x) = arrow::compute::sum(values) {
-            let v = self.sum.get_or_insert(T::Native::usize_as(0));
+            let v = self.sum.get_or_insert_with(|| T::Native::usize_as(0));
             *v = v.add_wrapping(x);
         }
         Ok(())

datafusion/physical-plan/src/joins/sort_merge_join/exec.rs

@@ -356,7 +356,7 @@ impl DisplayAs for SortMergeJoinExec {
                     "SortMergeJoin: join_type={:?}, on=[{}]{}",
                     self.join_type,
                     on,
-                    self.filter.as_ref().map_or("".to_string(), |f| format!(
+                    self.filter.as_ref().map_or_else(|| "".to_string(), |f| format!(
                         ", filter={}",
                         f.expression()
                     ))

datafusion/physical-plan/src/limit.rs

@@ -105,7 +105,7 @@ impl DisplayAs for GlobalLimitExec {
                     f,
                     "GlobalLimitExec: skip={}, fetch={}",
                     self.skip,
-                    self.fetch.map_or("None".to_string(), |x| x.to_string())
+                    self.fetch.map_or_else(|| "None".to_string(), |x| x.to_string())
                 )
             }
             DisplayFormatType::TreeRender => {

datafusion/spark/src/function/string/luhn_check.rs

@@ -149,5 +149,5 @@ fn luhn_check_impl(input: &str) -> bool {
         alt = !alt;
     }
 
-    digits_processed > 0 && sum % 10 == 0
+    digits_processed > 0 && sum.is_multiple_of(10)
 }