[branch-53] perf: Optimize array_concat using MutableArrayData (#20620)#118
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intobranch-53from May 4, 2026
Merged
Conversation
## Which issue does this PR close? - Closes apache#20619 . ## Rationale for this change The current implementation of `array_concat` creates an `ArrayRef` for each row, uses Arrow's `concat` kernel to merge the elements together, and then uses `concat` again to produce the final results. This does a lot of unnecessary allocation and copying. Instead, we can use `MutableArrayData::extend` to copy element ranges in bulk, which avoids much of this intermediate copying and allocation. This approach is 5-15x faster on a microbenchmark. ## What changes are included in this PR? * Add benchmark * Improve SLT test coverage for `array_concat` * Implement optimization ## Are these changes tested? Yes, and benchmarked. ## Are there any user-facing changes? No. (cherry picked from commit d2df7a5)
gabotechs
approved these changes
May 4, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
merged commit 4115a93
into
branch-53
65 of 66 checks passed
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick this PR: apache#20620.
This is intended to be a performance improvement, but it also fixes a bug in the way
array_concathandles null values that have a positive slot length.