add package-lock.json#26
Conversation
BridgeAR
left a comment
There was a problem hiding this comment.
We need to prevent the package-lock from being in a release. We just want the lockfile working for us. I think it would be good to use files in the package.json instead of using the npmignore file.
In addition we should activate dependabot or similar to update these in an automated way. That should be done at the same time as introducing this in my opinion.
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm install -g npm@7.24.2 # version of npm compatible with all tested node versions |
There was a problem hiding this comment.
Would this be updated with dependabot?
There was a problem hiding this comment.
hopefully not ? i had to find a npm version that both works with old and new node versions
There was a problem hiding this comment.
I see. That seems like a good reason to create a new major version where we drop support for Node.js versions < 18
package-lock.json always gets ignored by npm pack/publish (proof below) |
|
@BridgeAR I believe your required changes are irrelevant. As I said, the lock file is always ignored by npm publish (proof above), and there isn't much need for dependabot since this project only has dev dependencies. |
BridgeAR
left a comment
There was a problem hiding this comment.
I still think doing the two things I mentioned are better while this improves the situation as is, so I am fine to land it
No description provided.