Skip to content

add package-lock.json #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-id merged 5 commits into from
May 22, 2026
+3,088 −3
Merged

add package-lock.json #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f2d0e5
add package-lock.json
simon-id Apr 13, 2026
d26c659
Update pull-request.yml
simon-id Apr 13, 2026
bc1a274
test
simon-id Apr 13, 2026
6c1f99c
Update pull-request.yml
simon-id Apr 13, 2026
95194bd
Merge branch 'main' into add-package-lock.json
BridgeAR May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- uses: actions/setup-node@v1
with:
node-version: 20.6.1
- run: npm install
- run: npm ci
- run: npm run lint

package-report:
Expand Down Expand Up @@ -104,5 +104,6 @@ jobs:
- uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm install -g npm@7.24.2 # version of npm compatible with all tested node versions
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be updated with dependabot?

Copy link
Copy Markdown
Member Author

@simon-id simon-id Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully not ? i had to find a npm version that both works with old and new node versions

Copy link
Copy Markdown
Member

@BridgeAR BridgeAR May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. That seems like a good reason to create a new major version where we drop support for Node.js versions < 18

- run: npm ci
- run: npm test
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
node_modules/
package-lock.json
Loading
Loading