Skip to content

Commit c6e8fe9

Browse files
authored
Merge pull request #3574 from DataDog/jmoskovich/fix-merge-issue-rumviewscope
Fix issue with RumViewScope caused by merge
2 parents 456ca2c + ca3cf60 commit c6e8fe9

1 file changed

Lines changed: 8 additions & 26 deletions

File tree

  • features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScope.kt

Lines changed: 8 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -614,39 +614,21 @@ internal open class RumViewScope(
614614
trackFrustrations = trackFrustrations,
615615
sampleRate = sampleRate,
616616
rumSessionTypeOverride = rumSessionTypeOverride,
617-
insightsCollector = insightsCollector
617+
insightsCollector = insightsCollector,
618+
heatmapIdentifierRegistry = heatmapIdentifierRegistry
618619
)
619620
pendingActionCount++
620621
customActionScope.handleEvent(RumRawEvent.SendCustomActionNow(), datadogContext, writeScope, writer)
621622
return
622623
}
623624

624625
if (activeActionScope != null) {
625-
if (event.type == RumActionType.CUSTOM && !event.waitForStop) {
626-
// deliver it anyway, even if there is active action ongoing
627-
val customActionScope = RumActionScope.fromEvent(
628-
parentScope = this,
629-
sdkCore = sdkCore,
630-
event = event,
631-
timestampOffset = serverTimeOffsetInMs,
632-
featuresContextResolver = featuresContextResolver,
633-
trackFrustrations = trackFrustrations,
634-
sampleRate = sampleRate,
635-
rumSessionTypeOverride = rumSessionTypeOverride,
636-
insightsCollector = insightsCollector,
637-
heatmapIdentifierRegistry = heatmapIdentifierRegistry
638-
)
639-
pendingActionCount++
640-
customActionScope.handleEvent(RumRawEvent.SendCustomActionNow(), datadogContext, writeScope, writer)
641-
return
642-
} else {
643-
sdkCore.internalLogger.log(
644-
InternalLogger.Level.WARN,
645-
InternalLogger.Target.USER,
646-
{ ACTION_DROPPED_WARNING.format(Locale.US, event.type, event.name) }
647-
)
648-
return
649-
}
626+
sdkCore.internalLogger.log(
627+
InternalLogger.Level.WARN,
628+
InternalLogger.Target.USER,
629+
{ ACTION_DROPPED_WARNING.format(Locale.US, event.type, event.name) }
630+
)
631+
return
650632
}
651633

652634
activeActionScope = RumActionScope.fromEvent(

0 commit comments

Comments
 (0)