Skip to content

Add request to HttpResponseInfo.kt#3382

Merged
kikoveiga merged 2 commits into
developfrom
kikoveiga/add-request-to-HttpResponseInfo
Apr 27, 2026
Merged

Add request to HttpResponseInfo.kt#3382
kikoveiga merged 2 commits into
developfrom
kikoveiga/add-request-to-HttpResponseInfo

Conversation

@kikoveiga

Copy link
Copy Markdown
Contributor

What does this PR do?

Add a request property to HttpResponseInfo.

Motivation

Needed by #3338 to extract headers from the actual on-wire request, which contains all the headers after the chains.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga kikoveiga requested a review from satween April 21, 2026 09:59
@kikoveiga kikoveiga self-assigned this Apr 21, 2026
@kikoveiga kikoveiga requested review from a team as code owners April 21, 2026 09:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7fc91bca6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kikoveiga kikoveiga force-pushed the kikoveiga/add-request-to-HttpResponseInfo branch 3 times, most recently from f40686f to e5c6da8 Compare April 21, 2026 17:07
@codecov-commenter

codecov-commenter commented Apr 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.01%. Comparing base (261867c) to head (d167cb0).

Files with missing lines Patch % Lines
...g/android/cronet/internal/CronetRequestCallback.kt 50.00% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3382      +/-   ##
===========================================
- Coverage    72.04%   72.01%   -0.03%     
===========================================
  Files          959      959              
  Lines        35351    35358       +7     
  Branches      5864     5865       +1     
===========================================
- Hits         25468    25463       -5     
- Misses        8275     8280       +5     
- Partials      1608     1615       +7     
Files with missing lines Coverage Δ
.../android/cronet/internal/CronetHttpResponseInfo.kt 83.33% <100.00%> (+1.52%) ⬆️
...onet/internal/CronetRequestFinishedInfoListener.kt 91.67% <100.00%> (ø)
...adog/android/okhttp/internal/OkHttpResponseInfo.kt 91.18% <100.00%> (+0.27%) ⬆️
...g/android/cronet/internal/CronetRequestCallback.kt 85.00% <50.00%> (-2.27%) ⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga kikoveiga force-pushed the kikoveiga/add-request-to-HttpResponseInfo branch from 743c2d0 to 99d1492 Compare April 24, 2026 10:08
@kikoveiga kikoveiga requested a review from satween April 24, 2026 10:12
@kikoveiga kikoveiga force-pushed the kikoveiga/add-request-to-HttpResponseInfo branch 2 times, most recently from fd8033b to 8f70dcf Compare April 24, 2026 10:14
@kikoveiga kikoveiga force-pushed the kikoveiga/add-request-to-HttpResponseInfo branch from 8f70dcf to 7b6d7d1 Compare April 24, 2026 15:52
@kikoveiga kikoveiga force-pushed the kikoveiga/add-request-to-HttpResponseInfo branch from 7b6d7d1 to d167cb0 Compare April 24, 2026 15:53
@kikoveiga kikoveiga requested a review from satween April 24, 2026 16:11
@kikoveiga kikoveiga merged commit e40c7d7 into develop Apr 27, 2026
26 checks passed
@kikoveiga kikoveiga deleted the kikoveiga/add-request-to-HttpResponseInfo branch April 27, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants