Fix GraphQL errors extraction for streaming responses#3410
Merged
Conversation
54f2ecb to
bd5a0d4
Compare
bd5a0d4 to
98662bb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3410 +/- ##
===========================================
- Coverage 72.04% 71.97% -0.07%
===========================================
Files 960 960
Lines 35309 35310 +1
Branches 5851 5859 +8
===========================================
- Hits 25435 25411 -24
- Misses 8276 8290 +14
- Partials 1598 1609 +11
🚀 New features to boost your workflow:
|
98662bb to
4079e3c
Compare
4079e3c to
f0d8837
Compare
0xnm
approved these changes
May 4, 2026
jonathanmos
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
OkHttpGraphQLAdapter#extractGraphQLErrorAttributesso it returns early if there is a streaming response. Otherwise,peekBodymight deadlock as described in the issue below. This is exactly the same mechanism used insideDatadogInterceptor#getBodyLength.Motivation
#3407
Review checklist (to be filled by reviewers)