Add more asserts in unit tests

Author: anna-git

test/test_span_sampler.cpp

@@ -4,6 +4,7 @@
 #include <datadog/tags.h>
 #include <datadog/tracer.h>
 
+#include <algorithm>
 #include <cstddef>
 #include <ostream>
 #include <string>
@@ -271,6 +272,24 @@ TEST_CASE("span rule sample rate") {
   config.trace_sampler.sample_rate = 0.0;  // drop the trace
   auto finalized = finalize_config(config);
   REQUIRE(finalized);
+
+  // metadata should be populated right - check the full JSON representation
+  auto expected_rules = "[{\"name\":\"*\",\"resource\":\"*\",\"sample_rate\":" +
+                        to_string(test_case.span_rule_rate, 1) +
+                        ",\"service\":\"testsvc\",\"tags\":{}}]";
+  REQUIRE(finalized->metadata[ConfigName::SPAN_SAMPLING_RULES].value ==
+          expected_rules);
+
+  auto tracing_product = finalized->telemetry.products[0];
+
+  // Verify the tracing product has the span sampling rules in telemetry configs
+  const auto& span_rules_configs =
+      tracing_product.configurations.at(ConfigName::SPAN_SAMPLING_RULES);
+  REQUIRE(span_rules_configs.size() ==
+          1);  // Only CODE origin since rules were set in code
+  REQUIRE(span_rules_configs[0].value == expected_rules);
+  REQUIRE(span_rules_configs[0].origin == ConfigMetadata::Origin::CODE);
+
   Tracer tracer{*finalized};
   {
     auto span = tracer.create_span();

test/test_trace_sampler.cpp

@@ -5,11 +5,13 @@
 #include <datadog/tracer.h>
 #include <datadog/tracer_config.h>
 
+#include <algorithm>
 #include <chrono>
 #include <limits>
 #include <map>
 #include <ostream>
 
+#include "catch.hpp"
 #include "mocks/collectors.h"
 #include "null_logger.h"
 #include "test.h"
@@ -73,6 +75,21 @@ TEST_CASE("trace sampling rule sample rate") {
 
   auto finalized = finalize_config(config);
   REQUIRE(finalized);
+
+  // metadata should be populated right
+  REQUIRE(finalized->metadata[ConfigName::TRACE_SAMPLING_RATE].value ==
+          to_string(test_case.sample_rate, 1));
+
+  auto tracing_product = finalized->telemetry.products[0];
+  // Verify the tracing product has the telemetry configs
+  const auto& rate_configs =
+      tracing_product.configurations.at(ConfigName::TRACE_SAMPLING_RATE);
+  REQUIRE(rate_configs.size() == 2);
+  REQUIRE(rate_configs[0].value == to_string(1, 1));
+  REQUIRE(rate_configs[0].origin == ConfigMetadata::Origin::DEFAULT);
+  REQUIRE(rate_configs[1].value == to_string(test_case.sample_rate, 1));
+  REQUIRE(rate_configs[1].origin == ConfigMetadata::Origin::CODE);
+
   Tracer tracer{*finalized};
 
   for (std::size_t i = 0; i < num_iterations; ++i) {