Skip to content

fix(config-inversion): lowercase type fields and preserve implementation versions#305

Closed
genesor wants to merge 5 commits intomainfrom
ben.db/fix-lowercase-config-types
Closed

fix(config-inversion): lowercase type fields and preserve implementation versions#305
genesor wants to merge 5 commits intomainfrom
ben.db/fix-lowercase-config-types

Conversation

@genesor
Copy link
Copy Markdown
Member

@genesor genesor commented Apr 3, 2026

Description

Fixes to the config-inversion tool:

  1. Lowercase type fields (BOOLEANboolean, STRINGstring, etc.) in the generated supported-configurations.json.
  2. Preserve existing implementation version letters from the JSON file across regenerations instead of always resetting to "A".
  3. Serialize boolean defaults as "true"/"false" instead of "1"/"0".
  4. Fix version letters to match the config registry.
  5. Enable BACKFILLED: true in CI validation.

Motivation

The validate_supported_configurations_v2_local_file CI job was failing due to uppercase types, incorrect default serialization, and version letters being overwritten on each regeneration.

Additional Notes

Validation now passes with 0 errors.

Jira ticket: [APMSP-XXXX]

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 3, 2026

Benchmarks

Benchmark execution time: 2026-04-07 20:20:05

Comparing candidate commit 7c41e99 in PR branch ben.db/fix-lowercase-config-types with baseline commit 967246f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@datadog-prod-us1-3
Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.89% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7c41e99 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@genesor genesor closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant