chore(ci): use dd-sts for system-tests test optimization#306
Conversation
BenchmarksBenchmark execution time: 2026-04-13 15:26:27 Comparing candidate commit 74af748 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.
|
eb311bf to
3e7d454
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: 74af748 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcf3a3bd3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| permissions: | ||
| contents: read | ||
| packages: write | ||
| id-token: write |
There was a problem hiding this comment.
Propagate id-token permission to upstream workflow callers
Adding id-token: write here is not sufficient for all execution paths: dev.yml is invoked via workflow_call from .github/workflows/main.yml (job call-dev-workflow), and that caller explicitly grants only contents: read and packages: write. In reusable workflows, permissions cannot be elevated by the callee, so the system-tests job will not actually get an OIDC token in main/scheduled runs, which will break Datadog STS auth once this pin is updated to a dd-sts-enabled system-tests SHA.
Useful? React with 👍 / 👎.
Summary
Migrates system-tests CI to use dd-sts for Datadog Test Optimization instead of long-lived API keys.
All repositories now share a single
system-testspolicy (see dd-source#408172) — no per-repo policy is needed.Depends on DataDog/system-tests#6726.
Changes
id-token: writepermission to the system-tests reusable workflow call so it can obtain short-lived credentials via OIDC1e5d6b709(currentmain, pre-migration) to allow a controlled rollout: repos stay on the pre-migration workflow until their pin is explicitly updated to the post-merge SHAHow to review
The only functional change is adding
id-token: write. It has no effect at the pinned SHA (dd-sts is not yet used there) but will be required once each repo's pin is updated after DataDog/system-tests#6726 merges.