Skip to content

fix: use parentheses for signature_ init to match existing style#307

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
ayan.khan/fix-review-nits
Apr 14, 2026
Merged

fix: use parentheses for signature_ init to match existing style#307
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
ayan.khan/fix-review-nits

Conversation

@khanayan123
Copy link
Copy Markdown
Contributor

@khanayan123 khanayan123 commented Apr 14, 2026

Followup from #295 review feedback.

Changes signature_{...} to signature_(...) in the Tracer constructor member init list to match the parentheses style used by all other members (logger_(...), runtime_id_(...), etc.) & moves up root_session_id to be after runtime_id in tracer config

Ref: #295 (comment)

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 14, 2026

Benchmarks

Benchmark execution time: 2026-04-14 14:02:51

Comparing candidate commit 6c8ef24 in PR branch ayan.khan/fix-review-nits with baseline commit 34e7e68 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:BM_TraceTinyCCSource

  • 🟩 execution_time [-2.587ms; -2.475ms] or [-3.284%; -3.141%]

@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 bot commented Apr 14, 2026

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.94%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6c8ef24 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 14, 2026

View all feedbacks in Devflow UI.

2026-04-14 14:14:21 UTC ℹ️ Start processing command /merge


2026-04-14 14:14:26 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 36s (p90).


2026-04-14 14:18:04 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 1f76c5c into main Apr 14, 2026
70 of 71 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the ayan.khan/fix-review-nits branch April 14, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants