PR suggestions

andrewlock · andrewlock · commit 09bcc8b26f6c · 2026-02-18T10:07:18.000Z
diff --git a/tracer/src/Datadog.Trace/Configuration/Schema/ClientSchema.cs b/tracer/src/Datadog.Trace/Configuration/Schema/ClientSchema.cs
@@ -39,7 +39,7 @@ public ClientSchema(SchemaVersion version, bool peerServiceTagsEnabled, bool rem
             _serviceNames =
             [
                 useSuffix ? $"{defaultServiceName}-{HttpClientComponent}" : defaultServiceName,
-                useSuffix ? $"{defaultServiceName}-grpc-client" : defaultServiceName,
+                useSuffix ? $"{defaultServiceName}-{GrpcClientComponent}" : defaultServiceName,
             ];
             if (serviceNameMappings is not null)
             {
diff --git a/tracer/test/Datadog.Trace.Tests/Configuration/Schema/ClientSchemaTests.cs b/tracer/test/Datadog.Trace.Tests/Configuration/Schema/ClientSchemaTests.cs
@@ -48,9 +48,7 @@ public class ClientSchemaTests
         public static IEnumerable<(int SchemaVersion, string ExpectedSuffix)> GetOperationNameSuffixForRequestData()
         {
             yield return (0, string.Empty);           // SchemaVersion.V0
-            yield return (0,  string.Empty);
             yield return (1, ".request");   // SchemaVersion.V1
-            yield return (1, ".request");
         }
 
         [Theory]

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public ClientSchema(SchemaVersion version, bool peerServiceTagsEnabled, bool rem`
`39`	`39`	`_serviceNames =`
`40`	`40`	`[`
`41`	`41`	`useSuffix ? $"{defaultServiceName}-{HttpClientComponent}" : defaultServiceName,`
`42`		`- useSuffix ? $"{defaultServiceName}-grpc-client" : defaultServiceName,`
	`42`	`+ useSuffix ? $"{defaultServiceName}-{GrpcClientComponent}" : defaultServiceName,`
`43`	`43`	`];`
`44`	`44`	`if (serviceNameMappings is not null)`
`45`	`45`	`{`
Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,7 @@ public class ClientSchemaTests`
`48`	`48`	`public static IEnumerable<(int SchemaVersion, string ExpectedSuffix)> GetOperationNameSuffixForRequestData()`
`49`	`49`	`{`
`50`	`50`	`yield return (0, string.Empty); // SchemaVersion.V0`
`51`		`- yield return (0, string.Empty);`
`52`	`51`	`yield return (1, ".request"); // SchemaVersion.V1`
`53`		`- yield return (1, ".request");`
`54`	`52`	`}`
`55`	`53`
`56`	`54`	`[Theory]`