PR feedback

andrewlock · andrewlock · commit 1cd4ff97a2cb · 2026-04-22T11:50:45.000+01:00
diff --git a/tracer/src/Datadog.Trace/PDBs/DatadogMetadataReader.cs b/tracer/src/Datadog.Trace/PDBs/DatadogMetadataReader.cs
@@ -261,12 +261,12 @@ private int GetLocalVariablesCount(MethodDefinition method)
             if (PdbReader != null)
             {
                 var methodDefHandle = GetMethodDefHandle(methodToken);
-                var methodDef = GetMethodDef(methodDefHandle);
                 if (methodDefHandle.IsNil)
                 {
                     return null;
                 }
 
+                var methodDef = GetMethodDef(methodDefHandle);
                 MethodDebugInformation methodDebugInformation = PdbReader.GetMethodDebugInformation(methodDefHandle.ToDebugInformationHandle());
                 if (methodDebugInformation.SequencePointsBlob.IsNil && searchMoveNext)
                 {

Original file line number	Diff line number	Diff line change
`@@ -261,12 +261,12 @@ private int GetLocalVariablesCount(MethodDefinition method)`
`261`	`261`	`if (PdbReader != null)`
`262`	`262`	`{`
`263`	`263`	`var methodDefHandle = GetMethodDefHandle(methodToken);`
`264`		`- var methodDef = GetMethodDef(methodDefHandle);`
`265`	`264`	`if (methodDefHandle.IsNil)`
`266`	`265`	`{`
`267`	`266`	`return null;`
`268`	`267`	`}`
`269`	`268`
	`269`	`+ var methodDef = GetMethodDef(methodDefHandle);`
`270`	`270`	`MethodDebugInformation methodDebugInformation = PdbReader.GetMethodDebugInformation(methodDefHandle.ToDebugInformationHandle());`
`271`	`271`	`if (methodDebugInformation.SequencePointsBlob.IsNil && searchMoveNext)`
`272`	`272`	`{`