Skip to content

Commit 59dbf09

Browse files
authored
Stop vendoring resx for vendored microsoft code (#8461)
## Summary of changes Stop vendoring the `SR` + regex files for microsoft code ## Reason for change Using `ResourceManager` is overkill, as we don't deploy all the translations etc anyway, and don't want to. ## Implementation details Replaced all the `SR.` accesses in previous PRs, so this is now dead code that we can remove. ## Test coverage If it builds, we're good ## Other details https://datadoghq.atlassian.net/browse/APMLP-1207 Note that currently, there's a lot of `Utf8Formatter` code that _isn't_ used, and could be excluded, however, given that theoretically we could/should use this in the future. I'm torn whether to just leave it in, or whether to tear it out for now, and restore it if/when we want to use it later. Any thoughts? Part of a stack updating our vendored system code - #8391 - #8454 - #8455 - #8459
1 parent 8363350 commit 59dbf09

4 files changed

Lines changed: 0 additions & 434 deletions

File tree

tracer/build/_build/UpdateVendors/VendoredDependency.cs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -230,19 +230,6 @@ static VendoredDependency()
230230
},
231231
relativePathsToExclude: new [] { "Resources/Strings.resx" });
232232

233-
Add(
234-
libraryName: "System.Private.CoreLib",
235-
version: "1.0.0",
236-
downloadUrl: "https://github.com/DataDog/dotnet-vendored-code/archive/refs/tags/1.0.0.zip",
237-
pathToSrc: new[] { "dotnet-vendored-code-1.0.0", "System.Reflection.Metadata", "System.Private.CoreLib" },
238-
transform: filePath =>
239-
{
240-
241-
RewriteCsFileWithStandardTransform(filePath, originalNamespace: "System.Runtime", AddNullableDirectiveTransform, AddIgnoreNullabilityWarningDisablePragma);
242-
RewriteCsFileWithStandardTransform(filePath, originalNamespace: "System.Diagnostics", AddNullableDirectiveTransform, AddIgnoreNullabilityWarningDisablePragma);
243-
RewriteCsFileWithStandardTransform(filePath, originalNamespace: "FxResources", AddNullableDirectiveTransform, AddIgnoreNullabilityWarningDisablePragma);
244-
});
245-
246233
// "Common" shared components required by System.Reflection.Metadata (among others)
247234
// Not a "real" package
248235
Add(

0 commit comments

Comments
 (0)