Skip to content

Commit 9281c0d

Browse files
authored
Add artifacts for SLO checks to enable notifications (#8184)
## Summary of changes Add SLO check artifacts to the SLO check jobs to enable notifications. As a reminder: 1. We are not blocking on SLO breaches (we have `allow_failure: true`); 2. Notifications will only trigger on big regressions, since SLOs were set with a wide slack from benchmarking measurements. ## Reason for change Necessary to enable notification jobs. ## Implementation details ## Test coverage ## Other details <!-- Fixes #{issue} --> <!-- ⚠️ Note: Where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. MergeQueue is NOT enabled in this repository. If you have write access to the repo, the PR has 1-2 approvals (see above), and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #apm-dotnet channel in Slack. -->
1 parent 0b01a20 commit 9281c0d

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.gitlab/benchmarks/macrobenchmarks.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -743,6 +743,12 @@ check-slo-breaches:
743743
DDOCTOSTS_POLICY: "gitlab.github-access.read-contents"
744744
ARTIFACTS_DIR: "reports"
745745
SLO_FILE: ".gitlab/benchmarks/bp-runner.fail-on-breach.yml"
746+
artifacts:
747+
name: "artifacts"
748+
when: always
749+
paths:
750+
- reports/
751+
expire_in: 3 months
746752

747753
notify-slo-breaches:
748754
extends: .notify-slo-breaches

0 commit comments

Comments
 (0)