Commit 9863b8b
Set resource name after exception in OnEndRequest method (#8439)
When no resource-based sampling rules are configured, the resource name
was only set in OnEndRequest. If OnEndRequest doesn't complete (e.g.,
client disconnect), the resource name remained null and defaulted to the
operation name aspnet.request in Span.Finish(). This fix ensures the
resource name is always set early in OnBeginRequest. Fixes APMS-19184
Made-with: Cursor
## Summary of changes
## Reason for change
https://datadoghq.atlassian.net/browse/APMS-19184
## Implementation details
## Test coverage
## Other details
<!-- 1 parent b176976 commit 9863b8b
1 file changed
Lines changed: 27 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| 133 | + | |
| 134 | + | |
133 | 135 | | |
134 | 136 | | |
135 | | - | |
136 | | - | |
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| |||
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
266 | 278 | | |
267 | 279 | | |
268 | 280 | | |
| |||
417 | 429 | | |
418 | 430 | | |
419 | 431 | | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
420 | 444 | | |
421 | 445 | | |
422 | 446 | | |
| |||
0 commit comments