Skip to content

Commit ac5ec3d

Browse files
authored
Remove unused references to System.ServiceModelHttp (#8496)
## Summary of changes Removes unused references to [System.ServiceModel.Http](https://www.nuget.org/packages/System.ServiceModel.Http) package in the "dependencies" files ## Reason for change As far as I can tell, we don't (and haven't ever) actually instrumented this package. We only instrument the .NET Framework System.ServiceModel library. Having the NuGet package is confusing and misleading (and means we get dependabot alerts like [this one](#8131) ## Implementation details Remove the reference to the package ## Test coverage Ran `GeneratePackageVersions` locally, and it looked fine
1 parent 7520173 commit ac5ec3d

3 files changed

Lines changed: 2 additions & 27 deletions

File tree

tracer/build/_build/Honeypot/IntegrationGroups.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ static IntegrationMap()
7676
NugetPackages.Add("System.Data.SQLite", new [] { "System.Data.SQLite" });
7777
NugetPackages.Add("StackExchange.Redis", new [] { "StackExchange.Redis" });
7878
NugetPackages.Add("StackExchange.Redis.StrongName", new [] { "StackExchange.Redis.StrongName" });
79-
NugetPackages.Add("System.ServiceModel", new [] { "System.ServiceModel.Http" });
79+
NugetPackages.Add("System.ServiceModel", new string[] { });
8080
NugetPackages.Add("System.Net.Requests", new [] { "System.Net.Requests" });
8181
NugetPackages.Add("xunit.execution.dotnet", new [] { "xunit.extensibility.execution" });
8282
NugetPackages.Add("xunit.execution.desktop", new [] { "xunit" });

tracer/build/supported_versions.json

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1412,17 +1412,7 @@
14121412
"assemblyName": "System.ServiceModel",
14131413
"minAssemblyVersionInclusive": "4.0.0",
14141414
"maxAssemblyVersionInclusive": "4.65535.65535",
1415-
"packages": [
1416-
{
1417-
"name": "System.ServiceModel.Http",
1418-
"minVersionAvailableInclusive": "3.9.0",
1419-
"minVersionSupportedInclusive": "4.0.0",
1420-
"minVersionTestedInclusive": null,
1421-
"maxVersionSupportedInclusive": "4.10.3",
1422-
"maxVersionAvailableInclusive": "10.0.652802",
1423-
"maxVersionTestedInclusive": null
1424-
}
1425-
]
1415+
"packages": []
14261416
},
14271417
{
14281418
"integrationName": "WebRequest",

tracer/dependabot/integrations/Datadog.Dependabot.System.ServiceModel.Http.csproj

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)