Skip to content

Commit b0f41b6

Browse files
authored
Add .NET service names to macrobenchmarks (#8490)
## Summary of changes Adds `DD_SERVICE` to each of the benchmark jobs ## Reason for change Lets us compare between scenarios [in telemetry metrics](https://app.datadoghq.com/dashboard/55y-54i-63y?fromUser=false&refresh_mode=sliding&tpl_var_org_id%5B0%5D=197728&tpl_var_service%5B0%5D=gitlab-runner&from_ts=1776675694767&to_ts=1776762094767&live=true) ## Implementation details Manually added `DD_SERVICE` to each job ## Test coverage I'll trigger a manual run for the branch to confirm we can see this data as expected ## Other details We _may_ want to make the service name dynamic in the future, so we can isolate these to a specific commit, but I think that's not critical atm, given that these mostly only run on master, so we should _generally_ be able to distinguish based on start time (except when there are multiple commits to master)
1 parent 59dbf09 commit b0f41b6

1 file changed

Lines changed: 39 additions & 0 deletions

File tree

.gitlab/benchmarks/macrobenchmarks.yml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ build-dd-trace-dotnet-macrobenchmarks-ami:
157157
baseline-x86:
158158
extends: .benchmarks-x86
159159
variables:
160+
DD_SERVICE: baseline-x86
160161
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
161162
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
162163
COR_ENABLE_PROFILING: 0
@@ -166,6 +167,7 @@ baseline-x86:
166167
calltarget_ngen-x86:
167168
extends: .benchmarks-x86
168169
variables:
170+
DD_SERVICE: calltarget-ngen-x86
169171
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
170172
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
171173
COR_ENABLE_PROFILING: 1
@@ -177,6 +179,7 @@ calltarget_ngen-x86:
177179
single_span-x86:
178180
extends: .benchmarks-x86
179181
variables:
182+
DD_SERVICE: single-span-x86
180183
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
181184
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
182185
COR_ENABLE_PROFILING: 1
@@ -189,6 +192,7 @@ single_span-x86:
189192
trace_stats-x86:
190193
extends: .benchmarks-x86
191194
variables:
195+
DD_SERVICE: trace-stats-x86
192196
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
193197
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
194198
COR_ENABLE_PROFILING: 1
@@ -201,6 +205,7 @@ trace_stats-x86:
201205
manual_only-x86:
202206
extends: .benchmarks-x86
203207
variables:
208+
DD_SERVICE: manual-only-x86
204209
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
205210
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
206211
COR_ENABLE_PROFILING: 0
@@ -211,6 +216,7 @@ manual_only-x86:
211216
manual_and_automatic-x86:
212217
extends: .benchmarks-x86
213218
variables:
219+
DD_SERVICE: manual-and-automatic-x86
214220
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
215221
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
216222
COR_ENABLE_PROFILING: 1
@@ -221,6 +227,7 @@ manual_and_automatic-x86:
221227
ddtraceenabled_false-x86:
222228
extends: .benchmarks-x86
223229
variables:
230+
DD_SERVICE: ddtraceenabled-false-x86
224231
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
225232
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
226233
COR_ENABLE_PROFILING: 1
@@ -231,6 +238,7 @@ ddtraceenabled_false-x86:
231238
profiler_exceptions_baseline-x86:
232239
extends: .benchmarks-x86
233240
variables:
241+
DD_SERVICE: profiler-exceptions-baseline-x86
234242
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
235243
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
236244
COR_ENABLE_PROFILING: 0
@@ -240,6 +248,7 @@ profiler_exceptions_baseline-x86:
240248
profiler-x86:
241249
extends: .benchmarks-x86
242250
variables:
251+
DD_SERVICE: profiler-x86
243252
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
244253
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
245254
COR_ENABLE_PROFILING: 1
@@ -251,6 +260,7 @@ profiler-x86:
251260
profiler_walltime-x86:
252261
extends: .benchmarks-x86
253262
variables:
263+
DD_SERVICE: profiler-walltime-x86
254264
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
255265
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
256266
COR_ENABLE_PROFILING: 1
@@ -264,6 +274,7 @@ profiler_walltime-x86:
264274
profiler_exceptions-x86:
265275
extends: .benchmarks-x86
266276
variables:
277+
DD_SERVICE: profiler-exceptions-x86
267278
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
268279
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
269280
COR_ENABLE_PROFILING: 1
@@ -276,6 +287,7 @@ profiler_exceptions-x86:
276287
profiler_cpu-x86:
277288
extends: .benchmarks-x86
278289
variables:
290+
DD_SERVICE: profiler-cpu-x86
279291
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
280292
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
281293
COR_ENABLE_PROFILING: 1
@@ -289,6 +301,7 @@ profiler_cpu-x86:
289301
profiler_cpu_timer_create-x86:
290302
extends: .benchmarks-x86
291303
variables:
304+
DD_SERVICE: profiler-cpu-timer-create-x86
292305
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux/linux-x64/Datadog.Trace.ClrProfiler.Native.so"
293306
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux"
294307
COR_ENABLE_PROFILING: 1
@@ -354,6 +367,7 @@ baseline-arm64:
354367
extends: .benchmarks-arm64
355368
tags: ["runner:apm-k8s-arm-metal"]
356369
variables:
370+
DD_SERVICE: baseline-arm64
357371
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
358372
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
359373
COR_ENABLE_PROFILING: 0
@@ -364,6 +378,7 @@ calltarget_ngen-arm64:
364378
extends: .benchmarks-arm64
365379
tags: ["runner:apm-k8s-arm-metal"]
366380
variables:
381+
DD_SERVICE: calltarget-ngen-arm64
367382
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
368383
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
369384
COR_ENABLE_PROFILING: 1
@@ -376,6 +391,7 @@ single_span-arm64:
376391
extends: .benchmarks-arm64
377392
tags: ["runner:apm-k8s-arm-metal"]
378393
variables:
394+
DD_SERVICE: single-span-arm64
379395
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
380396
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
381397
COR_ENABLE_PROFILING: 1
@@ -389,6 +405,7 @@ trace_stats-arm64:
389405
extends: .benchmarks-arm64
390406
tags: ["runner:apm-k8s-arm-metal"]
391407
variables:
408+
DD_SERVICE: trace-stats-arm64
392409
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
393410
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
394411
COR_ENABLE_PROFILING: 1
@@ -402,6 +419,7 @@ manual_only-arm64:
402419
extends: .benchmarks-arm64
403420
tags: ["runner:apm-k8s-arm-metal"]
404421
variables:
422+
DD_SERVICE: manual-only-arm64
405423
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
406424
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
407425
COR_ENABLE_PROFILING: 0
@@ -413,6 +431,7 @@ manual_and_automatic-arm64:
413431
extends: .benchmarks-arm64
414432
tags: ["runner:apm-k8s-arm-metal"]
415433
variables:
434+
DD_SERVICE: manual-and-automatic-arm64
416435
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
417436
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
418437
COR_ENABLE_PROFILING: 1
@@ -424,6 +443,7 @@ ddtraceenabled_false-arm64:
424443
extends: .benchmarks-arm64
425444
tags: ["runner:apm-k8s-arm-metal"]
426445
variables:
446+
DD_SERVICE: ddtraceenabled-false-arm64
427447
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
428448
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
429449
COR_ENABLE_PROFILING: 1
@@ -435,6 +455,7 @@ profiler_exceptions_baseline-arm64:
435455
tags: ["runner:apm-k8s-arm-metal"]
436456
extends: .benchmarks-arm64
437457
variables:
458+
DD_SERVICE: profiler-exceptions-baseline-arm64
438459
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
439460
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
440461
COR_ENABLE_PROFILING: 0
@@ -445,6 +466,7 @@ profiler-arm64:
445466
tags: ["runner:apm-k8s-arm-metal"]
446467
extends: .benchmarks-arm64
447468
variables:
469+
DD_SERVICE: profiler-arm64
448470
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
449471
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
450472
COR_ENABLE_PROFILING: 1
@@ -457,6 +479,7 @@ profiler_walltime-arm64:
457479
tags: ["runner:apm-k8s-arm-metal"]
458480
extends: .benchmarks-arm64
459481
variables:
482+
DD_SERVICE: profiler-walltime-arm64
460483
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
461484
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
462485
COR_ENABLE_PROFILING: 1
@@ -471,6 +494,7 @@ profiler_exceptions-arm64:
471494
tags: ["runner:apm-k8s-arm-metal"]
472495
extends: .benchmarks-arm64
473496
variables:
497+
DD_SERVICE: profiler-exceptions-arm64
474498
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
475499
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
476500
COR_ENABLE_PROFILING: 1
@@ -484,6 +508,7 @@ profiler_cpu-arm64:
484508
tags: ["runner:apm-k8s-arm-metal"]
485509
extends: .benchmarks-arm64
486510
variables:
511+
DD_SERVICE: profiler-cpu-arm64
487512
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
488513
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
489514
COR_ENABLE_PROFILING: 1
@@ -498,6 +523,7 @@ profiler_cpu_timer_create-arm64:
498523
tags: ["runner:apm-k8s-arm-metal"]
499524
extends: .benchmarks-arm64
500525
variables:
526+
DD_SERVICE: profiler-cpu-timer-create-arm64
501527
NATIVE_PROFILER_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64/linux-arm64/Datadog.Trace.ClrProfiler.Native.so"
502528
TRACER_HOME_PATH: "dd-trace-dotnet/tracer/tracer-home-linux-arm64"
503529
COR_ENABLE_PROFILING: 1
@@ -604,11 +630,13 @@ profiler_cpu_timer_create-arm64:
604630
baseline-win:
605631
extends: .benchmarks-win
606632
variables:
633+
DD_SERVICE: baseline-win
607634
ENDPOINT: "hello"
608635

609636
calltarget_ngen-win:
610637
extends: .benchmarks-win
611638
variables:
639+
DD_SERVICE: calltarget-ngen-win
612640
COR_ENABLE_PROFILING: 1
613641
CORECLR_ENABLE_PROFILING: 1
614642
DD_CLR_ENABLE_INLINING: 1
@@ -618,6 +646,7 @@ calltarget_ngen-win:
618646
single_span-win:
619647
extends: .benchmarks-win
620648
variables:
649+
DD_SERVICE: single-span-win
621650
COR_ENABLE_PROFILING: 1
622651
CORECLR_ENABLE_PROFILING: 1
623652
DD_CLR_ENABLE_INLINING: 1
@@ -628,6 +657,7 @@ single_span-win:
628657
trace_stats-win:
629658
extends: .benchmarks-win
630659
variables:
660+
DD_SERVICE: trace-stats-win
631661
COR_ENABLE_PROFILING: 1
632662
CORECLR_ENABLE_PROFILING: 1
633663
DD_CLR_ENABLE_INLINING: 1
@@ -638,6 +668,7 @@ trace_stats-win:
638668
manual_only-win:
639669
extends: .benchmarks-win
640670
variables:
671+
DD_SERVICE: manual-only-win
641672
COR_ENABLE_PROFILING: 0
642673
CORECLR_ENABLE_PROFILING: 0
643674
DOTNET_BUILD_ARGS: "/p:MANUAL_INSTRUMENTATION=true /p:MANUAL_ONLY_INSTRUMENTATION=true"
@@ -646,6 +677,7 @@ manual_only-win:
646677
manual_and_automatic-win:
647678
extends: .benchmarks-win
648679
variables:
680+
DD_SERVICE: manual-and-automatic-win
649681
COR_ENABLE_PROFILING: 1
650682
CORECLR_ENABLE_PROFILING: 1
651683
DOTNET_BUILD_ARGS: "/p:MANUAL_INSTRUMENTATION=true"
@@ -654,6 +686,7 @@ manual_and_automatic-win:
654686
ddtraceenabled_false-win:
655687
extends: .benchmarks-win
656688
variables:
689+
DD_SERVICE: ddtraceenabled-false-win
657690
COR_ENABLE_PROFILING: 1
658691
CORECLR_ENABLE_PROFILING: 1
659692
DD_TRACE_ENABLED: 0
@@ -662,13 +695,15 @@ ddtraceenabled_false-win:
662695
profiler_exceptions_baseline-win:
663696
extends: .benchmarks-win
664697
variables:
698+
DD_SERVICE: profiler-exceptions-baseline-win
665699
COR_ENABLE_PROFILING: 0
666700
CORECLR_ENABLE_PROFILING: 0
667701
ENDPOINT: "hello/Exception"
668702

669703
profiler-win:
670704
extends: .benchmarks-win
671705
variables:
706+
DD_SERVICE: profiler-win
672707
COR_ENABLE_PROFILING: 1
673708
CORECLR_ENABLE_PROFILING: 1
674709
DD_PROFILING_ENABLED: 1
@@ -678,6 +713,7 @@ profiler-win:
678713
profiler_walltime-win:
679714
extends: .benchmarks-win
680715
variables:
716+
DD_SERVICE: profiler-walltime-win
681717
COR_ENABLE_PROFILING: 1
682718
CORECLR_ENABLE_PROFILING: 1
683719
DD_PROFILING_ENABLED: 1
@@ -689,6 +725,7 @@ profiler_walltime-win:
689725
profiler_exceptions-win:
690726
extends: .benchmarks-win
691727
variables:
728+
DD_SERVICE: profiler-exceptions-win
692729
COR_ENABLE_PROFILING: 1
693730
CORECLR_ENABLE_PROFILING: 1
694731
DD_PROFILING_ENABLED: 1
@@ -699,6 +736,7 @@ profiler_exceptions-win:
699736
profiler_cpu-win:
700737
extends: .benchmarks-win
701738
variables:
739+
DD_SERVICE: profiler-cpu-win
702740
COR_ENABLE_PROFILING: 1
703741
CORECLR_ENABLE_PROFILING: 1
704742
DD_PROFILING_ENABLED: 1
@@ -710,6 +748,7 @@ profiler_cpu-win:
710748
profiler_cpu_timer_create-win:
711749
extends: .benchmarks-win
712750
variables:
751+
DD_SERVICE: profiler-cpu-timer-create-win
713752
COR_ENABLE_PROFILING: 1
714753
CORECLR_ENABLE_PROFILING: 1
715754
DD_PROFILING_ENABLED: 1

0 commit comments

Comments
 (0)