Clean external warnings native (#8948)

## Summary of changes

Treat vendored spdlog/fmt headers as external in the native Windows
projects and filter routine NuGet restore progress, while preserving
warnings and errors.

## Reason for change

Native compilation and package restore produced thousands of low-value
lines. This is not expected to materially improve build time, but it
makes CI logs easier to inspect and future optimizations easier to
measure.

## Implementation details

Use MSVC external include paths with
`ExternalWarningLevel=TurnOffAllWarnings`, which generates
`/external:W0`. Use a NUKE custom logger to suppress routine NuGet
install, restore, add, and feed-probe messages.

## Test coverage

Validated with repeated GitLab Windows builds:

| Metric | Original | After warning + initial NuGet cleanup | Latest |
| --- | ---: | ---: | ---: |
| Lines | 17,699 | 7,894 | 3,585 |
| Size | 2.55 MiB | 1.21 MiB | 0.46 MiB |
| Targeted NuGet messages | 5,475 | 4,308 | 0 |
| Compiler warnings | 1,036 | 116 | 116 |
| Errors | 0 | 0 | 0 |

The final log is approximately 80% shorter. The remaining compiler
warnings originate in Datadog/PPDB code and remain visible as intended.

Author: NachoEchevarria

profiler/Directory.Build.props

@@ -188,7 +188,8 @@
       <DOTNET-TRACER-REPO-ROOT-PATH>$([System.IO.Path]::GetFullPath( $(EnlistmentRoot)/ ))</DOTNET-TRACER-REPO-ROOT-PATH>
       <SHARED-LIB-PATH>$(DOTNET-TRACER-REPO-ROOT-PATH)shared\src\native-lib\</SHARED-LIB-PATH>
       <CORECLR-PATH>$(SHARED-LIB-PATH)coreclr\src</CORECLR-PATH>
-      <SHARED-LIB-INCLUDES>$(SHARED-LIB-PATH)fmt\include;$(SHARED-LIB-PATH)spdlog\include</SHARED-LIB-INCLUDES>
+      <!-- Suppress warnings from vendored headers without suppressing warnings in Datadog code. -->
+      <ExternalIncludePath>$(SHARED-LIB-PATH)fmt\include;$(SHARED-LIB-PATH)spdlog\include;$(ExternalIncludePath)</ExternalIncludePath>
       <!-- VCPKG setup -->
       <VcpkgEnableManifest>true</VcpkgEnableManifest>
       <VcpkgUseStatic>false</VcpkgUseStatic>
@@ -207,6 +208,7 @@
                PatchSpdlogFile in tracer/build/_build/UpdateVendors/VendoredDependency.cs).
                Defined here on Windows for consistency. -->
         <PreprocessorDefinitions>%(PreprocessorDefinitions);MICROSOFT_WINDOWS_WINBASE_H_DEFINE_INTERLOCKED_CPLUSPLUS_OVERLOADS=1;FMT_UNICODE=0;DD_SPDLOG_NO_MDC</PreprocessorDefinitions>
+        <ExternalWarningLevel>TurnOffAllWarnings</ExternalWarningLevel>
 	      <BuildStlModules>false</BuildStlModules>
 	      <EnableModules>false</EnableModules>
       </ClCompile>

shared/src/Datadog.Trace.ClrProfiler.Native/Datadog.Trace.ClrProfiler.Native.vcxproj

@@ -43,7 +43,7 @@
     <DOTNET-TRACER-REPO-ROOT-PATH>..\..\..\</DOTNET-TRACER-REPO-ROOT-PATH>
     <SHARED-LIB-PATH>$(DOTNET-TRACER-REPO-ROOT-PATH)shared/src/native-lib/</SHARED-LIB-PATH>
     <LIB_INCLUDES>$(SHARED-LIB-PATH)coreclr\src\pal\prebuilt\inc</LIB_INCLUDES>
-    <SHARED-LIB-INCLUDES>$(SHARED-LIB-PATH)spdlog\include</SHARED-LIB-INCLUDES>
+    <ExternalIncludePath>$(SHARED-LIB-PATH)spdlog\include;$(ExternalIncludePath)</ExternalIncludePath>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
@@ -156,6 +156,8 @@
   </PropertyGroup>
   <ItemDefinitionGroup>
     <ClCompile>
+      <!-- Suppress warnings from vendored headers without suppressing warnings in Datadog code. -->
+      <ExternalWarningLevel>TurnOffAllWarnings</ExternalWarningLevel>
       <!-- spdlog 1.17 (and the bundled fmt 11+) need two build flags:
            - FMT_UNICODE=0: fmt 11+ static_asserts that narrow string literals are UTF-8.
              We don't compile with /utf-8 (would change the encoding of every narrow string in
@@ -390,4 +392,4 @@
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <ImportGroup Label="ExtensionTargets">
   </ImportGroup>
-</Project>
+</Project>

tracer/build/_build/Build.Steps.cs

@@ -294,9 +294,24 @@ bool RequiresThoroughTesting()
                 NuGetTasks.NuGetRestore(s => s
                     .SetTargetPath(Solution)
                     .SetVerbosity(NuGetVerbosity.Normal)
-                    .SetProcessLogOutput(!IsServerBuild)
+                    .SetProcessLogOutput(true)
                     .When(!string.IsNullOrEmpty(NugetPackageDirectory), o =>
-                        o.SetPackagesDirectory(NugetPackageDirectory)));
+                        o.SetPackagesDirectory(NugetPackageDirectory))
+                    .When(IsServerBuild || IsGitlab, o =>
+                        o.SetProcessCustomLogger((type, text) =>
+                        {
+                            var trimmedText = text.TrimStart();
+                            if (!trimmedText.StartsWith("Installed ", StringComparison.Ordinal) &&
+                                !trimmedText.StartsWith("Restoring NuGet package ", StringComparison.Ordinal) &&
+                                !trimmedText.StartsWith("Adding package '", StringComparison.Ordinal) &&
+                                !trimmedText.StartsWith("Added package '", StringComparison.Ordinal) &&
+                                !trimmedText.StartsWith("GET ", StringComparison.Ordinal) &&
+                                !trimmedText.StartsWith("OK ", StringComparison.Ordinal) &&
+                                !trimmedText.StartsWith("NotFound ", StringComparison.Ordinal))
+                            {
+                                NuGetTasks.NuGetLogger(type, text);
+                            }
+                        })));
             }
             else
             {

tracer/src/Datadog.Tracer.Native/Datadog.Tracer.Native.DLL.vcxproj

@@ -41,7 +41,8 @@
     <RootNamespace>DatadogTraceClrProfilerNativeDLL</RootNamespace>
     <WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
     <LIB_PATH>..\..\..\shared\src\native-lib\</LIB_PATH>
-    <LIB_INCLUDES>$(LIB_PATH)spdlog\include;$(LIB_PATH)coreclr\src\pal\prebuilt\inc</LIB_INCLUDES>
+    <LIB_INCLUDES>$(LIB_PATH)coreclr\src\pal\prebuilt\inc</LIB_INCLUDES>
+    <ExternalIncludePath>$(LIB_PATH)spdlog\include;$(ExternalIncludePath)</ExternalIncludePath>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
@@ -142,6 +143,8 @@
   </PropertyGroup>
   <ItemDefinitionGroup>
     <ClCompile>
+      <!-- Suppress warnings from vendored headers without suppressing warnings in Datadog code. -->
+      <ExternalWarningLevel>TurnOffAllWarnings</ExternalWarningLevel>
       <!-- spdlog 1.17 (and the bundled fmt 11+) need two build flags:
            - FMT_UNICODE=0: fmt 11+ static_asserts that narrow string literals are UTF-8.
              We don't compile with /utf-8 (would change the encoding of every narrow string in
@@ -344,4 +347,4 @@
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <ImportGroup Label="ExtensionTargets">
   </ImportGroup>
-</Project>
+</Project>

tracer/src/Datadog.Tracer.Native/Datadog.Tracer.Native.vcxproj

@@ -43,7 +43,8 @@
     <CORECLR_PATH>..\..\..\shared\src\native-lib\coreclr</CORECLR_PATH>
     <ProjectName>Datadog.Tracer.Native</ProjectName>
     <LIB_PATH>..\..\..\shared\src\native-lib\</LIB_PATH>
-    <LIB_INCLUDES>$(CORECLR_PATH)\src\pal\prebuilt\inc;$(CORECLR_PATH)\src\inc;$(VC_IncludePath);$(WindowsSDK_IncludePath);$(LIB_PATH)spdlog\include</LIB_INCLUDES>
+    <LIB_INCLUDES>$(CORECLR_PATH)\src\pal\prebuilt\inc;$(CORECLR_PATH)\src\inc;$(VC_IncludePath);$(WindowsSDK_IncludePath)</LIB_INCLUDES>
+    <ExternalIncludePath>$(LIB_PATH)spdlog\include;$(ExternalIncludePath)</ExternalIncludePath>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
@@ -119,6 +120,8 @@
   </PropertyGroup>
   <ItemDefinitionGroup>
     <ClCompile>
+      <!-- Suppress warnings from vendored headers without suppressing warnings in Datadog code. -->
+      <ExternalWarningLevel>TurnOffAllWarnings</ExternalWarningLevel>
       <!-- spdlog 1.17 (and the bundled fmt 11+) need two build flags:
            - FMT_UNICODE=0: fmt 11+ static_asserts that narrow string literals are UTF-8.
              We don't compile with /utf-8 (would change the encoding of every narrow string in
@@ -417,4 +420,4 @@
     <ClCompile Include="tracer_tokens.cpp" />
   </ItemGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
-</Project>
+</Project>