Andrew/r and d/non recording spans

[andrewlock]

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

[dd-trace-dotnet-ci-bot]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7916) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	74.09 ± (73.95 - 74.48) ms	74.52 ± (74.41 - 74.92) ms	+0.6%	✅⬆️
.NET Framework 4.8 - Bailout
duration	76.97 ± (76.92 - 77.27) ms	77.37 ± (77.35 - 77.70) ms	+0.5%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1105.31 ± (1105.54 - 1114.90) ms	1105.49 ± (1107.18 - 1115.21) ms	+0.0%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.34 ± (22.30 - 22.38) ms	22.50 ± (22.45 - 22.55) ms	+0.7%	✅⬆️
process.time_to_main_ms	83.71 ± (83.51 - 83.92) ms	85.14 ± (84.87 - 85.41) ms	+1.7%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.92 ± (10.92 - 10.93) MB	10.94 ± (10.93 - 10.94) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.49 ± (22.45 - 22.52) ms	22.38 ± (22.33 - 22.43) ms	-0.5%	✅
process.time_to_main_ms	85.42 ± (85.19 - 85.64) ms	85.65 ± (85.46 - 85.84) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.96 ± (10.96 - 10.96) MB	10.97 ± (10.96 - 10.97) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	216.37 ± (215.59 - 217.14) ms	213.30 ± (212.40 - 214.19) ms	-1.4%	✅
process.time_to_main_ms	546.16 ± (544.83 - 547.48) ms	543.42 ± (542.20 - 544.63) ms	-0.5%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	48.39 ± (48.36 - 48.42) MB	48.63 ± (48.61 - 48.66) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.5%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	21.36 ± (21.31 - 21.40) ms	21.40 ± (21.34 - 21.46) ms	+0.2%	✅⬆️
process.time_to_main_ms	73.84 ± (73.67 - 74.02) ms	75.02 ± (74.75 - 75.29) ms	+1.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.62 ± (10.62 - 10.63) MB	10.63 ± (10.63 - 10.63) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	21.52 ± (21.46 - 21.58) ms	21.37 ± (21.32 - 21.41) ms	-0.7%	✅
process.time_to_main_ms	76.97 ± (76.67 - 77.26) ms	76.85 ± (76.62 - 77.08) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.74 ± (10.74 - 10.75) MB	10.74 ± (10.74 - 10.74) MB	-0.0%	✅
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	368.27 ± (366.16 - 370.38) ms	372.03 ± (370.07 - 373.98) ms	+1.0%	✅⬆️
process.time_to_main_ms	546.53 ± (545.18 - 547.87) ms	550.47 ± (549.17 - 551.76) ms	+0.7%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	50.06 ± (50.04 - 50.08) MB	50.08 ± (50.05 - 50.10) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.1%	✅
.NET 8 - Baseline
process.internal_duration_ms	19.36 ± (19.33 - 19.39) ms	19.35 ± (19.32 - 19.38) ms	-0.0%	✅
process.time_to_main_ms	72.73 ± (72.56 - 72.90) ms	72.61 ± (72.44 - 72.78) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.67 ± (7.66 - 7.67) MB	7.68 ± (7.68 - 7.69) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.49 ± (19.44 - 19.53) ms	19.71 ± (19.65 - 19.76) ms	+1.1%	✅⬆️
process.time_to_main_ms	74.44 ± (74.21 - 74.66) ms	76.37 ± (76.11 - 76.63) ms	+2.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.72 ± (7.72 - 7.73) MB	7.73 ± (7.72 - 7.73) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	297.66 ± (295.69 - 299.63) ms	296.73 ± (294.47 - 298.98) ms	-0.3%	✅
process.time_to_main_ms	497.15 ± (496.05 - 498.24) ms	502.89 ± (501.48 - 504.29) ms	+1.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	37.00 ± (36.97 - 37.03) MB	36.94 ± (36.92 - 36.97) MB	-0.1%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.2%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	196.98 ± (196.45 - 197.40) ms	198.42 ± (198.19 - 199.04) ms	+0.7%	✅⬆️
.NET Framework 4.8 - Bailout
duration	200.85 ± (200.64 - 201.68) ms	201.23 ± (201.05 - 202.01) ms	+0.2%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1189.01 ± (1187.91 - 1193.66) ms	1096.59 ± (1095.71 - 1100.84) ms	-7.8%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	191.41 ± (190.96 - 191.87) ms	191.68 ± (191.19 - 192.17) ms	+0.1%	✅⬆️
process.time_to_main_ms	83.07 ± (82.82 - 83.32) ms	82.90 ± (82.67 - 83.14) ms	-0.2%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.12 ± (16.10 - 16.14) MB	16.11 ± (16.08 - 16.13) MB	-0.1%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	+0.2%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	190.92 ± (190.48 - 191.37) ms	192.36 ± (191.89 - 192.82) ms	+0.8%	✅⬆️
process.time_to_main_ms	84.16 ± (83.89 - 84.43) ms	84.65 ± (84.41 - 84.89) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.16 ± (16.14 - 16.18) MB	16.14 ± (16.12 - 16.16) MB	-0.1%	✅
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (21 - 21)	+0.1%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	384.94 ± (383.70 - 386.18) ms	309.54 ± (308.25 - 310.83) ms	-19.6%	✅
process.time_to_main_ms	531.14 ± (529.74 - 532.53) ms	535.56 ± (534.26 - 536.85) ms	+0.8%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	57.24 ± (57.13 - 57.34) MB	50.01 ± (49.97 - 50.05) MB	-12.6%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.9%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	195.55 ± (195.07 - 196.04) ms	196.86 ± (196.44 - 197.28) ms	+0.7%	✅⬆️
process.time_to_main_ms	71.41 ± (71.20 - 71.61) ms	72.21 ± (72.00 - 72.42) ms	+1.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.36 ± (16.33 - 16.38) MB	16.40 ± (16.37 - 16.43) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	+0.1%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	195.71 ± (195.22 - 196.20) ms	195.65 ± (195.30 - 196.00) ms	-0.0%	✅
process.time_to_main_ms	72.43 ± (72.28 - 72.58) ms	72.89 ± (72.73 - 73.05) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.42 ± (16.39 - 16.45) MB	16.44 ± (16.41 - 16.46) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.8%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	581.81 ± (578.86 - 584.76) ms	479.40 ± (476.88 - 481.91) ms	-17.6%	✅
process.time_to_main_ms	540.28 ± (539.21 - 541.35) ms	540.05 ± (538.99 - 541.11) ms	-0.0%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	61.15 ± (61.08 - 61.23) MB	53.04 ± (53.02 - 53.07) MB	-13.3%	✅
runtime.dotnet.threads.count	31 ± (31 - 31)	31 ± (31 - 31)	-0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	193.49 ± (192.97 - 194.00) ms	195.04 ± (194.55 - 195.54) ms	+0.8%	✅⬆️
process.time_to_main_ms	71.11 ± (70.87 - 71.36) ms	71.73 ± (71.53 - 71.93) ms	+0.9%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.71 ± (11.69 - 11.73) MB	11.71 ± (11.68 - 11.73) MB	-0.0%	✅
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 18)	-0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	192.34 ± (191.83 - 192.86) ms	194.63 ± (194.34 - 194.92) ms	+1.2%	✅⬆️
process.time_to_main_ms	71.69 ± (71.51 - 71.88) ms	72.81 ± (72.63 - 72.99) ms	+1.6%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.78 ± (11.76 - 11.80) MB	11.74 ± (11.72 - 11.77) MB	-0.4%	✅
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	+0.2%	✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	513.71 ± (511.36 - 516.06) ms	408.05 ± (405.92 - 410.18) ms	-20.6%	✅
process.time_to_main_ms	489.98 ± (489.08 - 490.88) ms	491.57 ± (490.80 - 492.35) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	50.68 ± (50.64 - 50.72) MB	39.72 ± (39.69 - 39.75) MB	-21.6%	✅
runtime.dotnet.threads.count	29 ± (29 - 30)	30 ± (29 - 30)	+0.4%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7916) - mean (75ms)  : 71, 79
    master - mean (74ms)  : 70, 78

    section Bailout
    This PR (7916) - mean (78ms)  : 75, 80
    master - mean (77ms)  : 75, 79

    section CallTarget+Inlining+NGEN
    This PR (7916) - mean (1,111ms)  : 1054, 1169
    master - mean (1,110ms)  : 1042, 1179

Loading

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7916) - mean (115ms)  : 110, 119
    master - mean (113ms)  : 108, 118

    section Bailout
    This PR (7916) - mean (115ms)  : 112, 118
    master - mean (115ms)  : 112, 118

    section CallTarget+Inlining+NGEN
    This PR (7916) - mean (793ms)  : 767, 819
    master - mean (799ms)  : 765, 833

Loading

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7916) - mean (103ms)  : 97, 109
    master - mean (102ms)  : 98, 105

    section Bailout
    This PR (7916) - mean (105ms)  : 101, 109
    master - mean (105ms)  : 100, 110

    section CallTarget+Inlining+NGEN
    This PR (7916) - mean (953ms)  : 921, 985
    master - mean (943ms)  : 908, 979

Loading

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7916) - mean (100ms)  : 97, 103
    master - mean (100ms)  : 97, 103

    section Bailout
    This PR (7916) - mean (104ms)  : 98, 110
    master - mean (102ms)  : 97, 107

    section CallTarget+Inlining+NGEN
    This PR (7916) - mean (829ms)  : 785, 874
    master - mean (826ms)  : 784, 868

Loading

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7916) - mean (199ms)  : 194, 203
    master - mean (197ms)  : 191, 203

    section Bailout
    This PR (7916) - mean (202ms)  : 197, 206
    master - mean (201ms)  : 196, 207

    section CallTarget+Inlining+NGEN
    This PR (7916) - mean (1,098ms)  : 1063, 1134
    master - mean (1,191ms)  : 1149, 1232

Loading

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7916) - mean (284ms)  : 276, 291
    master - mean (283ms)  : 272, 294

    section Bailout
    This PR (7916) - mean (286ms)  : 276, 296
    master - mean (285ms)  : 277, 293

    section CallTarget+Inlining+NGEN
    This PR (7916) - mean (885ms)  : 860, 910
    master - mean (956ms)  : 936, 976

Loading

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7916) - mean (277ms)  : 272, 282
    master - mean (275ms)  : 268, 283

    section Bailout
    This PR (7916) - mean (277ms)  : 273, 281
    master - mean (277ms)  : 271, 283

    section CallTarget+Inlining+NGEN
    This PR (7916) - mean (1,047ms)  : 1012, 1081
    master - mean (1,151ms)  : 1101, 1201

Loading

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7916) - mean (276ms)  : 271, 282
    master - mean (275ms)  : 268, 281

    section Bailout
    This PR (7916) - mean (277ms)  : 273, 281
    master - mean (274ms)  : 268, 280

    section CallTarget+Inlining+NGEN
    This PR (7916) - mean (930ms)  : 897, 962
    master - mean (1,036ms)  : 1000, 1071

Loading

[datadog-datadog-prod-us1]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-dotnet | run-benchmarks     

🔧 Fix in code (Fix with Cursor).

Benchmark execution failed due to a System.NullReferenceException in Benchmarks.Trace.Iast.StringAspectsBenchmark.InitTaintedContext.

Verify source generator changes have been persisted | verify_source_generators     

🔧 Fix in code (Fix with Cursor).

Found changes in Generated folder. Ensure all source generated files are committed after local build.

Label PRs | add-labels     

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.

PR validation failed: No labels found in PR.

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1909db4 | Docs | Datadog PR Page | Give us feedback!}