[SymDB] Increase SymDB upload batch default to 1MB#8193
Conversation
| // TODO: Consider streaming SymDB payload bytes directly to the stream | ||
| // to avoid the extra `string -> UTF8 bytes` encoding step and intermediate byte[] allocations/copies. | ||
| // Similar allocation reductions were done in https://github.com/DataDog/dd-trace-dotnet/pull/8017 | ||
| // and https://github.com/DataDog/dd-trace-dotnet/pull/8019). |
There was a problem hiding this comment.
I would suggest that we should do this before merging this PR as allocating multiple 1MB blocks is likely going to be a source of perf issues...
3d514b3 to
f85b318
Compare
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-05-27 15:49:25 Comparing candidate commit f85b318 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.
|
Summary of changes
Update the default SymDB upload batch size from 100KB to 1MB (DD_SYMBOL_DATABASE_BATCH_SIZE_BYTES still overrides).
Update DebuggerSettingsTests to assert against DebuggerSettings.DefaultSymbolBatchSizeInBytes.
Reason for change
We have to keep number of uploads as low as possible.
Test coverage
DebuggerSettingsTestsand existingSymbolUploaderTest