Skip to content

Update Testcontainers to v4 and migrate to ICollectionFixture - #8350

Open
bouwkast wants to merge 2 commits into
masterfrom
steven/update-test-containers-4
Open

Update Testcontainers to v4 and migrate to ICollectionFixture#8350
bouwkast wants to merge 2 commits into
masterfrom
steven/update-test-containers-4

Conversation

@bouwkast

@bouwkast bouwkast commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

This upgrades Testcontainers to v4 in preparation for more migration of integration tests to use this over normal docker compose files.

This also removes the ContainersRegistry and instead just uses xUnit's ICollectionFixture as previously the actual containers were not being disposed of (in CI they do get cleaned up after the job ends from my understanding) but locally the container would just stay running.

Reason for change

I find it tedious to have to do a docker compose up .... every time that I want to run integration tests locally I would much rather just get to a point where we just can run the test and let the infrastructure handle everything else. This sets us up to start doing that.

Implementation details

  • Bumped Testcontainers version, fixed build errors / API changes
  • Add Newtonsoft.Json reference to TestHelpers.AutoInstrumentation as it was complaining that it wasn't there
  • Migrated AerospikeTests to be the new way

Test coverage

Ran locally before/after there are no differences (outside of the fact that the container is properly disposed now)

Other details

I'll be plugging away at the other integrations

@bouwkast
bouwkast requested review from a team as code owners March 20, 2026 15:44
@bouwkast bouwkast mentioned this pull request Mar 20, 2026
Closed
@github-actions github-actions Bot added the area:tests unit tests, integration tests label Mar 20, 2026
@pr-commenter

pr-commenter Bot commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-29 15:08:54

Comparing candidate commit 36b956d in PR branch steven/update-test-containers-4 with baseline commit 2302d41 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-5159.888op/s; -4927.991op/s] or [-5.890%; -5.626%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-9608.889op/s; -9208.000op/s] or [-11.393%; -10.918%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-9948.523op/s; -8587.677op/s] or [-10.115%; -8.732%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+302.961ms; +305.449ms] or [+150.340%; +151.574%]
  • 🟥 throughput [-51.611op/s; -47.525op/s] or [-9.286%; -8.551%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+378.656ms; +380.142ms] or [+299.161%; +300.336%]
  • 🟩 throughput [+94.093op/s; +96.642op/s] or [+12.406%; +12.742%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+395.184ms; +397.235ms] or [+349.723%; +351.538%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.693KB; +4.694KB] or [+98.806%; +98.821%]
  • 🟥 throughput [-60210.180op/s; -59831.293op/s] or [-46.847%; -46.552%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.816KB; +3.816KB] or [+80.699%; +80.711%]
  • 🟩 execution_time [-15.937ms; -11.744ms] or [-7.443%; -5.485%]
  • 🟥 throughput [-59980.642op/s; -57206.934op/s] or [-43.782%; -41.758%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.544KB; +4.544KB] or [+98.261%; +98.274%]
  • 🟥 throughput [-48629.724op/s; -46376.436op/s] or [-43.967%; -41.930%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.316KB; +1.316KB] or [+106.475%; +106.490%]
  • 🟥 throughput [-266199.193op/s; -262226.795op/s] or [-27.180%; -26.775%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+479 bytes; +480 bytes] or [+39.212%; +39.221%]
  • 🟩 execution_time [-28.437ms; -12.924ms] or [-12.682%; -5.764%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.280KB; +1.280KB] or [+105.947%; +105.963%]
  • 🟥 throughput [-158845.550op/s; -142679.366op/s] or [-22.823%; -20.500%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-72919.604op/s; -72121.062op/s] or [-49.074%; -48.537%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-73590.845op/s; -70715.572op/s] or [-46.825%; -44.995%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-56532.470op/s; -53916.538op/s] or [-45.035%; -42.952%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+282518.018op/s; +318435.372op/s] or [+9.420%; +10.618%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-19.505ms; -15.172ms] or [-8.991%; -6.994%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+300.163ms; +300.824ms] or [+149.981%; +150.312%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+299.148ms; +302.263ms] or [+150.861%; +152.432%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+299.457ms; +302.725ms] or [+150.843%; +152.489%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+295.968ms; +297.068ms] or [+145.368%; +145.908%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+296.383ms; +300.768ms] or [+144.891%; +147.034%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+303.282ms; +306.580ms] or [+151.580%; +153.228%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+26.561µs; +50.288µs] or [+8.480%; +16.054%]
  • 🟥 throughput [-463.281op/s; -263.782op/s] or [-14.442%; -8.223%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.834ms; +300.642ms] or [+149.648%; +150.051%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+420.984ms; +427.609ms] or [+457.416%; +464.615%]
  • 🟩 throughput [+874.867op/s; +1050.977op/s] or [+7.189%; +8.636%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟥 execution_time [+369.224ms; +374.042ms] or [+280.348%; +284.006%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+324.060ms; +373.697ms] or [+149.000%; +171.822%]
  • 🟥 throughput [-545.006op/s; -498.551op/s] or [-49.383%; -45.174%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+214.076ms; +347.293ms] or [+91.230%; +148.002%]
  • 🟥 throughput [-671.599op/s; -588.102op/s] or [-44.796%; -39.227%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+350.247ms; +359.819ms] or [+209.488%; +215.213%]
  • 🟥 throughput [-406.185op/s; -368.813op/s] or [-28.282%; -25.680%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-194.445µs; -144.717µs] or [-9.850%; -7.331%]
  • 🟩 throughput [+41.947op/s; +55.661op/s] or [+8.281%; +10.988%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+302.197ms; +303.746ms] or [+152.181%; +152.961%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+300.179ms; +302.225ms] or [+150.420%; +151.446%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+300.467ms; +304.163ms] or [+150.942%; +152.799%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+303.435ms; +304.789ms] or [+152.375%; +153.055%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+298.352ms; +300.461ms] or [+147.522%; +148.565%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+304.785ms; +308.701ms] or [+154.478%; +156.463%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+300.476ms; +301.894ms] or [+150.812%; +151.524%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+295.946ms; +299.817ms] or [+147.502%; +149.431%]
  • 🟩 throughput [+45002.618op/s; +54028.283op/s] or [+8.936%; +10.728%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+300.232ms; +304.730ms] or [+149.363%; +151.601%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.647ms; -12.929ms] or [-7.741%; -6.012%]
  • 🟩 throughput [+19925.290op/s; +27189.742op/s] or [+5.466%; +7.459%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+18.973µs; +61.906µs] or [+4.686%; +15.291%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-20.841KB; -20.819KB] or [-7.602%; -7.594%]
  • unstable execution_time [-44.581µs; +10.560µs] or [-8.811%; +2.087%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-40.794µs; +23.197µs] or [-7.069%; +4.020%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+5.843µs; +11.087µs] or [+13.812%; +26.207%]
  • 🟥 throughput [-4770.689op/s; -2787.677op/s] or [-20.083%; -11.735%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.984µs; -7.894µs] or [-23.247%; -12.247%]
  • 🟩 throughput [+1947.222op/s; +3470.082op/s] or [+11.947%; +21.290%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+304.539ms; +305.810ms] or [+153.931%; +154.573%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+303.794ms; +305.934ms] or [+154.630%; +155.719%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+301.047ms; +303.492ms] or [+150.711%; +151.935%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • 🟥 throughput [-20443.531op/s; -18315.932op/s] or [-5.659%; -5.070%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+26503.769op/s; +36605.356op/s] or [+5.017%; +6.929%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+297.562ms; +299.975ms] or [+148.308%; +149.511%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+300.986ms; +302.593ms] or [+151.141%; +151.948%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.822ms; +305.126ms] or [+153.572%; +154.740%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.707ms; +301.969ms] or [+149.994%; +150.624%]
  • 🟩 throughput [+65836161.369op/s; +66198913.531op/s] or [+47.946%; +48.210%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+421.192ms; +426.053ms] or [+523.828%; +529.872%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+300.295ms; +301.444ms] or [+149.780%; +150.353%]
  • 🟩 throughput [+17904227.612op/s; +18893570.800op/s] or [+7.930%; +8.369%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+81182.368op/s; +90821.249op/s] or [+7.580%; +8.480%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+63520.625op/s; +73818.078op/s] or [+6.309%; +7.331%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+38245.474op/s; +46745.180op/s] or [+6.945%; +8.488%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+22502.791op/s; +32118.170op/s] or [+5.037%; +7.189%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+78265.100op/s; +95271.973op/s] or [+8.744%; +10.644%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8350) and master.

⚠️ Potential regressions detected

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration204.99 ± (204.93 - 205.88) ms216.85 ± (216.40 - 217.39) ms+5.8%❌⬆️
Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration71.68 ± (71.73 - 72.16) ms73.44 ± (73.09 - 73.64) ms+2.5%✅⬆️
.NET Framework 4.8 - Bailout
duration78.42 ± (78.10 - 78.59) ms78.57 ± (78.14 - 78.69) ms+0.2%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1087.49 ± (1086.77 - 1093.07) ms1084.51 ± (1083.14 - 1088.75) ms-0.3%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.38 ± (22.34 - 22.42) ms22.34 ± (22.29 - 22.38) ms-0.2%✅
process.time_to_main_ms84.10 ± (83.85 - 84.36) ms84.56 ± (84.28 - 84.83) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.98 ± (10.98 - 10.99) MB11.00 ± (11.00 - 11.01) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.04 ± (22.02 - 22.07) ms21.95 ± (21.93 - 21.98) ms-0.4%✅
process.time_to_main_ms83.68 ± (83.47 - 83.88) ms83.11 ± (82.91 - 83.30) ms-0.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed11.03 ± (11.03 - 11.03) MB11.04 ± (11.04 - 11.05) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms209.92 ± (209.02 - 210.82) ms209.84 ± (209.08 - 210.60) ms-0.0%✅
process.time_to_main_ms538.02 ± (536.78 - 539.25) ms537.79 ± (536.71 - 538.86) ms-0.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.53 ± (49.50 - 49.56) MB49.55 ± (49.52 - 49.58) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.3%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms20.81 ± (20.78 - 20.84) ms20.98 ± (20.93 - 21.02) ms+0.8%✅⬆️
process.time_to_main_ms71.63 ± (71.46 - 71.80) ms71.96 ± (71.71 - 72.21) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.71 ± (10.71 - 10.71) MB10.72 ± (10.71 - 10.72) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.77 ± (20.74 - 20.80) ms21.06 ± (21.02 - 21.10) ms+1.4%✅⬆️
process.time_to_main_ms72.61 ± (72.48 - 72.74) ms74.62 ± (74.41 - 74.84) ms+2.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.83 ± (10.83 - 10.84) MB10.84 ± (10.84 - 10.85) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms372.11 ± (369.95 - 374.27) ms372.79 ± (370.58 - 375.00) ms+0.2%✅⬆️
process.time_to_main_ms547.53 ± (546.34 - 548.72) ms543.58 ± (542.38 - 544.78) ms-0.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.64 ± (50.62 - 50.66) MB50.62 ± (50.60 - 50.65) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.2%✅
.NET 8 - Baseline
process.internal_duration_ms19.47 ± (19.42 - 19.52) ms19.25 ± (19.22 - 19.27) ms-1.2%✅
process.time_to_main_ms73.39 ± (73.14 - 73.63) ms69.95 ± (69.83 - 70.08) ms-4.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.75 ± (7.74 - 7.75) MB7.78 ± (7.77 - 7.78) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.18 ± (19.14 - 19.21) ms19.16 ± (19.12 - 19.19) ms-0.1%✅
process.time_to_main_ms72.38 ± (72.19 - 72.57) ms71.22 ± (71.11 - 71.34) ms-1.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.80 ± (7.80 - 7.80) MB7.81 ± (7.81 - 7.82) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms294.06 ± (292.12 - 296.01) ms297.42 ± (295.16 - 299.68) ms+1.1%✅⬆️
process.time_to_main_ms503.80 ± (502.44 - 505.15) ms494.86 ± (493.91 - 495.80) ms-1.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed38.01 ± (37.99 - 38.04) MB38.16 ± (38.13 - 38.19) MB+0.4%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.8%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration204.99 ± (204.93 - 205.88) ms216.85 ± (216.40 - 217.39) ms+5.8%❌⬆️
.NET Framework 4.8 - Bailout
duration209.74 ± (209.44 - 210.44) ms219.25 ± (219.17 - 220.25) ms+4.5%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1238.61 ± (1237.15 - 1243.33) ms1292.65 ± (1295.71 - 1304.29) ms+4.4%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms196.67 ± (196.24 - 197.10) ms207.15 ± (206.75 - 207.55) ms+5.3%✅⬆️
process.time_to_main_ms86.31 ± (86.02 - 86.60) ms92.15 ± (91.78 - 92.51) ms+6.8%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.15 ± (16.12 - 16.18) MB16.09 ± (16.07 - 16.11) MB-0.4%✅
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+1.4%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms196.83 ± (196.36 - 197.29) ms206.75 ± (206.31 - 207.18) ms+5.0%✅⬆️
process.time_to_main_ms87.47 ± (87.24 - 87.70) ms93.39 ± (93.14 - 93.63) ms+6.8%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.15 ± (16.12 - 16.17) MB16.16 ± (16.14 - 16.18) MB+0.1%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.9%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms390.74 ± (389.32 - 392.16) ms407.49 ± (406.02 - 408.96) ms+4.3%✅⬆️
process.time_to_main_ms551.71 ± (550.51 - 552.92) ms576.87 ± (575.22 - 578.52) ms+4.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.97 ± (58.75 - 59.19) MB59.82 ± (59.75 - 59.88) MB+1.4%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+1.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms203.15 ± (202.78 - 203.52) ms210.90 ± (210.34 - 211.46) ms+3.8%✅⬆️
process.time_to_main_ms76.14 ± (75.92 - 76.36) ms80.36 ± (80.07 - 80.65) ms+5.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.55 ± (16.52 - 16.57) MB16.35 ± (16.32 - 16.38) MB-1.2%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 20)+1.4%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms203.41 ± (203.07 - 203.76) ms210.12 ± (209.61 - 210.63) ms+3.3%✅⬆️
process.time_to_main_ms78.01 ± (77.83 - 78.19) ms81.32 ± (81.09 - 81.56) ms+4.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.53 ± (16.51 - 16.54) MB16.41 ± (16.38 - 16.44) MB-0.7%✅
runtime.dotnet.threads.count20 ± (20 - 20)21 ± (20 - 21)+1.7%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms584.38 ± (582.15 - 586.61) ms581.39 ± (579.09 - 583.70) ms-0.5%✅
process.time_to_main_ms562.58 ± (561.31 - 563.85) ms590.08 ± (589.00 - 591.16) ms+4.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.61 ± (61.52 - 61.70) MB61.59 ± (61.51 - 61.68) MB-0.0%✅
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms200.95 ± (200.57 - 201.33) ms212.39 ± (211.90 - 212.89) ms+5.7%✅⬆️
process.time_to_main_ms74.52 ± (74.22 - 74.82) ms80.50 ± (80.26 - 80.75) ms+8.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.84 ± (11.81 - 11.86) MB11.82 ± (11.80 - 11.84) MB-0.1%✅
runtime.dotnet.threads.count19 ± (18 - 19)19 ± (19 - 19)+2.3%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms201.31 ± (200.89 - 201.72) ms211.62 ± (211.13 - 212.12) ms+5.1%✅⬆️
process.time_to_main_ms76.04 ± (75.85 - 76.23) ms81.91 ± (81.61 - 82.21) ms+7.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.85 ± (11.82 - 11.87) MB11.85 ± (11.82 - 11.87) MB-0.0%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.7%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms511.03 ± (505.70 - 516.35) ms533.97 ± (527.27 - 540.67) ms+4.5%✅⬆️
process.time_to_main_ms514.59 ± (513.52 - 515.67) ms542.82 ± (541.86 - 543.77) ms+5.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed51.34 ± (51.28 - 51.40) MB51.53 ± (51.45 - 51.60) MB+0.4%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (30 - 30)+1.0%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (73ms)  : 69, 78
    master - mean (72ms)  : 69, 75

    section Bailout
    This PR (8350) - mean (78ms)  : 74, 83
    master - mean (78ms)  : 75, 82

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (1,086ms)  : 1046, 1126
    master - mean (1,090ms)  : 1044, 1135
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (114ms)  : 110, 119
    master - mean (114ms)  : 108, 120

    section Bailout
    This PR (8350) - mean (112ms)  : 107, 116
    master - mean (113ms)  : 108, 118

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (785ms)  : 756, 814
    master - mean (786ms)  : 766, 805
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (99ms)  : 94, 104
    master - mean (98ms)  : 95, 102

    section Bailout
    This PR (8350) - mean (103ms)  : 98, 107
    master - mean (99ms)  : 97, 102

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (945ms)  : 908, 983
    master - mean (949ms)  : 915, 982
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (96ms)  : 93, 98
    master - mean (101ms)  : 96, 106

    section Bailout
    This PR (8350) - mean (97ms)  : 95, 99
    master - mean (99ms)  : 95, 104

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (822ms)  : 781, 862
    master - mean (830ms)  : 787, 872
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (217ms)  : 212, 222
    master - mean (205ms)  : 200, 211

    section Bailout
    This PR (8350) - mean (220ms)  : 214, 226
    master - mean (210ms)  : 205, 215

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (1,300ms)  : 1235, 1365
    master - mean (1,240ms)  : 1194, 1286
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (310ms)  : 305, 316
    master - mean (293ms)  : 285, 301

    section Bailout
    This PR (8350) - mean (311ms)  : 305, 316
    master - mean (294ms)  : 288, 301

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (1,027ms)  : 1003, 1051
    master - mean (984ms)  : 958, 1010
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (302ms)  : 295, 309
    master - mean (289ms)  : 284, 294

    section Bailout
    This PR (8350) - mean (301ms)  : 295, 308
    master - mean (291ms)  : 287, 296

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (1,212ms)  : 1166, 1259
    master - mean (1,180ms)  : 1144, 1216
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (304ms)  : 293, 315
    master - mean (286ms)  : 280, 291

    section Bailout
    This PR (8350) - mean (305ms)  : crit, 298, 312
    master - mean (288ms)  : 283, 293

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (1,125ms)  : 1026, 1224
    master - mean (1,062ms)  : 989, 1135
Loading

@bouwkast
bouwkast force-pushed the steven/update-test-containers-4 branch 2 times, most recently from 31eb9a6 to dafcf50 Compare March 27, 2026 20:12
@bouwkast
bouwkast force-pushed the steven/update-test-containers-4 branch from dafcf50 to 59a8b4a Compare April 8, 2026 13:14
andrewlock
andrewlock approved these changes Apr 13, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're sure this works where you have the same container used on multiple tests then looks good, but that's the scenario we should test IMO 🙂

Comment thread tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/Helpers/ContainersCollection.cs
{
[CollectionDefinition(Name)]

public class AerospikeCollection : ICollectionFixture<AerospikeFixture>

@andrewlock andrewlock Apr 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels... weird 😅 I hate the loosey-goosey ness of this wiring up. But that's just xunit for you 🤷‍♂️

Comment thread ...Datadog.Trace.ClrProfiler.IntegrationTests/Datadog.Trace.ClrProfiler.IntegrationTests.csproj
<PackageReference Include="System.Collections.Immutable" Version="6.0.0" />

<PackageReference Include="Testcontainers" Version="3.6.0" />
<PackageReference Include="Testcontainers" Version="4.11.0" />

@andrewlock andrewlock Apr 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any breaking changes we actually care about out of interest?

@bouwkast bouwkast Apr 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest one that I noticed was that they appeared to go from Docker.Dotnet to their own Docker.Dotnet.Enhanced which required the Newtonsoft.Json dependency

The other changes seemed quite small from what I found

Comment thread tracer/test/Datadog.Trace.TestHelpers.AutoInstrumentation/Containers/ContainerFixture.cs
_resources = await InitializeResources().ConfigureAwait(false);
}

// Do not implement, the ContainersRegistry is responsible for disposing the containers

@andrewlock andrewlock Apr 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, as per the original PR:

Because fixtures are not singleton, the ContainersRegistry is used to store the objects across multiple fixtures.

that seems like it would still be an issue? 🤔 Should we just make sure to call Dispose on the registry from the custom test helper before it shuts down? 🤔

FWIW, leaving the containers running may have been intentional, for faster inner-loop dev 😄

@andrewlock andrewlock Apr 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realised that the original was using IClassFixture not IContainerFixture but still, we should prob check that they Are singletons in this case...

@bouwkast bouwkast Apr 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I'll look into this

@bouwkast bouwkast Apr 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay from what I can tell running it locally with this and with my other PRs #8353 and #8430 it seems to be the case that they are all singletons

I think leaving the containers running was intentional

I guess that is something that we could come back to if it proves to be beneficial in the future, I guess it matches our current behavior in CI and local dev where the containers are spun up and left running

@bouwkast
bouwkast force-pushed the steven/update-test-containers-4 branch from 59a8b4a to dca3189 Compare April 23, 2026 20:04
@bouwkast
bouwkast force-pushed the steven/update-test-containers-4 branch from 4309c8a to bea5df3 Compare June 11, 2026 11:24
@bouwkast
bouwkast force-pushed the steven/update-test-containers-4 branch from bea5df3 to 36b956d Compare July 29, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bouwkast @andrewlock