Stop vendoring resx for vendored microsoft code#8461
Stop vendoring resx for vendored microsoft code#8461andrewlock wants to merge 1 commit intoandrew/update-vendors-3from
Conversation
BenchmarksBenchmark execution time: 2026-04-21 11:25:06 Comparing candidate commit 7dc44a2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8461) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (73ms) : 71, 75
master - mean (73ms) : 70, 77
section Bailout
This PR (8461) - mean (80ms) : 75, 84
master - mean (77ms) : 75, 79
section CallTarget+Inlining+NGEN
This PR (8461) - mean (1,075ms) : 1027, 1122
master - mean (1,075ms) : 1030, 1121
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (116ms) : 109, 124
master - mean (116ms) : 108, 123
section Bailout
This PR (8461) - mean (117ms) : 111, 123
master - mean (115ms) : 111, 118
section CallTarget+Inlining+NGEN
This PR (8461) - mean (772ms) : 752, 793
master - mean (797ms) : 773, 821
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (103ms) : 97, 109
master - mean (102ms) : 95, 108
section Bailout
This PR (8461) - mean (102ms) : 99, 105
master - mean (103ms) : 98, 108
section CallTarget+Inlining+NGEN
This PR (8461) - mean (936ms) : 902, 970
master - mean (940ms) : 906, 974
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (101ms) : 96, 106
master - mean (100ms) : 96, 103
section Bailout
This PR (8461) - mean (104ms) : 100, 108
master - mean (103ms) : 97, 108
section CallTarget+Inlining+NGEN
This PR (8461) - mean (822ms) : 786, 858
master - mean (825ms) : 786, 865
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (192ms) : 188, 195
master - mean (191ms) : 188, 195
section Bailout
This PR (8461) - mean (195ms) : 193, 197
master - mean (195ms) : 193, 196
section CallTarget+Inlining+NGEN
This PR (8461) - mean (1,150ms) : 1108, 1192
master - mean (1,153ms) : 1101, 1205
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (274ms) : 270, 278
master - mean (274ms) : 270, 278
section Bailout
This PR (8461) - mean (275ms) : 273, 278
master - mean (275ms) : 271, 279
section CallTarget+Inlining+NGEN
This PR (8461) - mean (926ms) : 902, 949
master - mean (930ms) : 903, 957
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (269ms) : 265, 272
master - mean (267ms) : 263, 272
section Bailout
This PR (8461) - mean (269ms) : 266, 272
master - mean (268ms) : 265, 271
section CallTarget+Inlining+NGEN
This PR (8461) - mean (1,143ms) : 1081, 1204
master - mean (1,138ms) : 1099, 1176
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8461) - mean (279ms) : 257, 302
master - mean (266ms) : 261, 271
section Bailout
This PR (8461) - mean (270ms) : 266, 274
master - mean (266ms) : 263, 268
section CallTarget+Inlining+NGEN
This PR (8461) - mean (1,050ms) : 982, 1119
master - mean (1,019ms) : 981, 1057
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
7f66c52 to
3b42dd4
Compare
bdf65ae to
ef58938
Compare
3b42dd4 to
2e151f2
Compare
ef58938 to
7dc44a2
Compare
Summary of changes
Stop vendoring the
SR+ regex files for microsoft codeReason for change
Using
ResourceManageris overkill, as we don't deploy all the translations etc anyway, and don't want to.Implementation details
Replaced all the
SR.accesses in previous PRs, so this is now dead code that we can remove.Test coverage
If it builds, we're good
Other details
https://datadoghq.atlassian.net/browse/APMLP-1207
Note that currently, there's a lot of
Utf8Formattercode that isn't used, and could be excluded, however, given that theoretically we could/should use this in the future. I'm torn whether to just leave it in, or whether to tear it out for now, and restore it if/when we want to use it later. Any thoughts?Part of a stack updating our vendored system code