Skip to content

Cleanup and fix the GeneratePackageVersions#8478

Merged
bouwkast merged 4 commits intomasterfrom
steven/cooldown-fix
Apr 22, 2026
Merged

Cleanup and fix the GeneratePackageVersions#8478
bouwkast merged 4 commits intomasterfrom
steven/cooldown-fix

Conversation

@bouwkast
Copy link
Copy Markdown
Collaborator

@bouwkast bouwkast commented Apr 17, 2026 •
edited
Loading

Summary of changes

This goes back through the recent changes (#8371 and #8340) to GeneratePackageVersions and attempts to do some removals, refactorings, and fixes that have come up. Notably this removes the nuget_cache, fixes IncludePackages (again 😅), and rewrites the cooldown logic to not use supported_versions.json and nuget_cache and instead reads from the .g.cs files in addition to refactoring the verbage used throughout.

Reason for change

While working on (#8128) I started running into several issues with GeneratePackageVersions namely that I couldn't get IncludePackages to work and then I started fighting issues with the nuget_cache as well when attempting to add a new integration.

This sets out to do a few things:

  • Simplify the logic for NuGet cooldown (automated dependency updates must adhere to our current cooldown policy for potential supply chain attacks)
  • Remove the nuget_cache - this was added so that we wouldn't go and query NuGet info for packages not listed in the IncludePackages
  • Change the "verbage" of the cooldown/baseline to be easier to read / follow
  • Do NOT read / rely upon supported_versions (this is what I previously used to determine what the highest version was currently allowed) - this file is planned to be changed/modified/removed by another team in the near future hence why we shouldn't use it.
  • I didn't account for different timezones in the publish state of the nuget_cache before so if someone ran it depending on their locale it would change.

Implementation details

  • New CooldownMode enum: Normal, BypassCooldown, Freeze
    • Normal drops recent versions that are above the previous max
    • BypassCooldown accepts all in-range versions (no cooldown) (when IncludePackages is used is an example)
    • Freeze re-emits the previous run's output verbatim
  • XUnitFileGenerator.LoadExistingVersions reads the previous .g.cs and returns Dictionary<IntegrationName, List<(Framework, Versions)>>. PackageGroup loads this once and exposes TryGetFrozenVersions
    • I think we should probably still try and do something different here but this seems a bit more reasonable
  • Deleted nuget_version_cache.json and NuGetVersionCache.cs
    • No longer used/needed
  • Some readability improvements
    • IsWithinCooldown → WasPublishedTooRecently
    • baseline → previousMaxVersions
    • ApplyCooldown now uses two named local booleans (publishedTooRecently, atOrBelowPreviousMax) so the drop condition reads positively: "drop the version if it was published too recently and we haven't already shipped against it."

Test coverage

I ran it locally for a handful of cases I think it is better.

Other details

I have ran through several instances with this and it seems to be good, basically default runs, runs with configurable cooldowns, runs with IncludePackages and runs with ExcludePackages. All appeared as expected to me.

@bouwkast bouwkast added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Apr 17, 2026
@github-actions github-actions Bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 17, 2026
@bouwkast
Copy link
Copy Markdown
Collaborator Author

bouwkast commented Apr 17, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 17, 2026

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 17, 2026 •
edited
Loading

Benchmarks

Benchmark execution time: 2026-04-21 20:49:43

Comparing candidate commit 5774103 in PR branch steven/cooldown-fix with baseline commit e36a35c in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 26 metrics, 0 unstable metrics, 87 known flaky benchmarks.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-4821.590op/s; -4555.869op/s] or [-5.504%; -5.201%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • ignore allocated_mem [+0 bytes; +1 bytes] or [+0.020%; +0.032%]
  • ignore execution_time [-1376.817µs; -428.487µs] or [-0.684%; -0.213%]
  • ignore throughput [-1069.663op/s; -533.579op/s] or [-1.268%; -0.633%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.007%]
  • ignore execution_time [-1855.118µs; +1647.454µs] or [-0.926%; +0.822%]
  • 🟩 throughput [+8268.563op/s; +10690.158op/s] or [+6.950%; +8.986%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.007%]
  • ignore execution_time [-225.402µs; +2101.969µs] or [-0.113%; +1.057%]
  • ignore throughput [-1038.204op/s; +171.513op/s] or [-1.056%; +0.174%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • ignore allocated_mem [-20 bytes; -19 bytes] or [-0.613%; -0.600%]
  • 🟥 execution_time [+308.184ms; +310.156ms] or [+152.932%; +153.910%]
  • ignore throughput [+6.244op/s; +10.104op/s] or [+1.123%; +1.818%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.009%; +0.002%]
  • 🟥 execution_time [+378.672ms; +382.086ms] or [+299.174%; +301.872%]
  • ignore throughput [+6.698op/s; +10.319op/s] or [+0.883%; +1.361%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.009%; +0.002%]
  • 🟥 execution_time [+399.517ms; +401.744ms] or [+353.558%; +355.528%]
  • ignore throughput [+0.192op/s; +4.324op/s] or [+0.027%; +0.611%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.529%; +27.541%]
  • ignore execution_time [-308.579µs; +263.571µs] or [-0.154%; +0.132%]
  • ignore throughput [-4315.568op/s; -3931.967op/s] or [-3.358%; -3.059%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.977%; +9.987%]
  • 🟩 execution_time [-15.829ms; -11.600ms] or [-7.393%; -5.418%]
  • ignore throughput [+5206.021op/s; +8060.745op/s] or [+3.800%; +5.884%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.502%; +27.510%]
  • ignore execution_time [-10.831ms; -6.696ms] or [-5.158%; -3.189%]
  • ignore throughput [-987.876op/s; +1307.667op/s] or [-0.893%; +1.182%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.746%; +105.759%]
  • ignore execution_time [-809.060µs; -90.262µs] or [-0.403%; -0.045%]
  • 🟥 throughput [-257612.606op/s; -253873.241op/s] or [-26.304%; -25.922%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.558%; +38.566%]
  • 🟩 execution_time [-26.332ms; -15.465ms] or [-11.743%; -6.897%]
  • 🟥 throughput [-83720.885op/s; -53255.480op/s] or [-8.944%; -5.689%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.292%; +105.304%]
  • ignore execution_time [-1.163ms; +3.185ms] or [-0.580%; +1.590%]
  • 🟥 throughput [-138131.754op/s; -121921.837op/s] or [-19.847%; -17.518%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [-1052.172µs; -15.610µs] or [-0.524%; -0.008%]
  • ignore throughput [-47.566op/s; +723.114op/s] or [-0.032%; +0.487%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.003%]
  • ignore execution_time [+0.254ms; +3.752ms] or [+0.128%; +1.893%]
  • 🟩 throughput [+10443.888op/s; +13439.544op/s] or [+6.645%; +8.551%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [-7.922ms; +1.985ms] or [-4.039%; +1.012%]
  • 🟩 throughput [+6526.714op/s; +9185.034op/s] or [+5.199%; +7.317%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.004%]
  • ignore execution_time [-340.143µs; -120.068µs] or [-0.170%; -0.060%]
  • ignore throughput [+53765.953op/s; +66364.152op/s] or [+1.636%; +2.019%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.008%]
  • ignore execution_time [-2.902ms; -0.611ms] or [-1.435%; -0.302%]
  • 🟩 throughput [+467804.037op/s; +502628.236op/s] or [+15.599%; +16.760%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.004%]
  • 🟩 execution_time [-19.139ms; -14.770ms] or [-8.823%; -6.808%]
  • 🟩 throughput [+216934.911op/s; +270719.638op/s] or [+8.611%; +10.746%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • ignore allocated_mem [+0 bytes; +2 bytes] or [-0.001%; +0.007%]
  • 🟥 execution_time [+299.457ms; +300.139ms] or [+149.628%; +149.969%]
  • ignore throughput [+135.353op/s; +153.022op/s] or [+1.495%; +1.690%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • ignore allocated_mem [-1 bytes; +2 bytes] or [-0.004%; +0.008%]
  • 🟥 execution_time [+298.720ms; +302.190ms] or [+150.645%; +152.395%]
  • ignore throughput [+335.267op/s; +547.855op/s] or [+2.564%; +4.190%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +2 bytes] or [-0.004%; +0.008%]
  • 🟥 execution_time [+299.308ms; +301.901ms] or [+150.768%; +152.074%]
  • ignore throughput [+159.920op/s; +288.091op/s] or [+1.544%; +2.781%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • ignore allocated_mem [+3 bytes; +4 bytes] or [+0.186%; +0.199%]
  • 🟥 execution_time [+296.659ms; +297.132ms] or [+145.707%; +145.939%]
  • ignore throughput [-9.061op/s; -3.400op/s] or [-0.240%; -0.090%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • 🟥 execution_time [+294.892ms; +296.756ms] or [+144.162%; +145.073%]
  • ignore throughput [+166.978op/s; +207.564op/s] or [+2.426%; +3.016%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • 🟥 execution_time [+302.217ms; +303.360ms] or [+151.048%; +151.619%]
  • ignore throughput [+28.967op/s; +45.141op/s] or [+0.575%; +0.896%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [+6.941µs; +11.009µs] or [+1.425%; +2.260%]
  • ignore throughput [-45.065op/s; -28.469op/s] or [-2.195%; -1.387%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.000%; +0.010%]
  • 🟥 execution_time [+25.347µs; +52.054µs] or [+5.813%; +11.939%]
  • 🟥 throughput [-253.100op/s; -132.982op/s] or [-11.004%; -5.782%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.003%]
  • ignore execution_time [+13.351µs; +36.733µs] or [+2.861%; +7.870%]
  • ignore throughput [-172.333op/s; -87.563op/s] or [-7.955%; -4.042%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-4.156µs; -0.306µs] or [-1.122%; -0.083%]
  • ignore throughput [+2.804op/s; +30.503op/s] or [+0.104%; +1.130%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.007%]
  • 🟥 execution_time [+25.244µs; +48.967µs] or [+8.059%; +15.633%]
  • 🟥 throughput [-451.842op/s; -252.411op/s] or [-14.085%; -7.868%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.003%]
  • ignore execution_time [-11385.459ns; +10979.459ns] or [-3.115%; +3.004%]
  • ignore throughput [-115.841op/s; +17.579op/s] or [-4.157%; +0.631%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.905ms; +300.585ms] or [+149.684%; +150.023%]
  • ignore throughput [+3479829.414op/s; +4046888.041op/s] or [+1.743%; +2.027%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • ignore allocated_mem [+75 bytes; +77 bytes] or [+0.419%; +0.431%]
  • unstable execution_time [+335.464ms; +380.782ms] or [+364.495%; +413.735%]
  • 🟩 throughput [+1091.459op/s; +1233.898op/s] or [+8.969%; +10.139%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • ignore allocated_mem [+20 bytes; +22 bytes] or [+0.099%; +0.110%]
  • unstable execution_time [+304.913ms; +343.190ms] or [+231.517%; +260.581%]
  • 🟩 throughput [+694.730op/s; +894.245op/s] or [+6.725%; +8.657%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • ignore allocated_mem [+2.657KB; +2.662KB] or [+4.720%; +4.729%]
  • unstable execution_time [+360.391ms; +434.474ms] or [+165.705%; +199.767%]
  • 🟥 throughput [-522.749op/s; -462.311op/s] or [-47.366%; -41.890%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • ignore allocated_mem [-1.268KB; -1.266KB] or [-2.991%; -2.985%]
  • unstable execution_time [+203.131ms; +336.348ms] or [+86.566%; +143.337%]
  • 🟥 throughput [-744.838op/s; -661.322op/s] or [-49.681%; -44.110%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • ignore allocated_mem [+2.047KB; +2.050KB] or [+4.833%; +4.841%]
  • 🟥 execution_time [+350.463ms; +359.308ms] or [+209.618%; +214.908%]
  • 🟥 throughput [-481.258op/s; -447.498op/s] or [-33.509%; -31.159%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-46.935µs; -27.062µs] or [-2.362%; -1.362%]
  • ignore throughput [+7.273op/s; +12.480op/s] or [+1.445%; +2.480%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-57.638µs; -43.294µs] or [-3.960%; -2.974%]
  • ignore throughput [+21.418op/s; +28.778op/s] or [+3.118%; +4.189%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-124.556µs; -70.594µs] or [-4.333%; -2.456%]
  • ignore throughput [+8.289op/s; +18.736op/s] or [+2.383%; +5.386%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-12.171µs; -3.321µs] or [-1.051%; -0.287%]
  • ignore throughput [+2.865op/s; +9.320op/s] or [+0.332%; +1.079%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-19.408µs; -4.687µs] or [-1.800%; -0.435%]
  • ignore throughput [+5.222op/s; +17.720op/s] or [+0.563%; +1.911%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [+54.011µs; +63.231µs] or [+2.894%; +3.387%]
  • ignore throughput [-17.574op/s; -14.997op/s] or [-3.280%; -2.799%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472

  • ignore allocated_mem [-43 bytes; +21 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [+11.527µs; +30.466µs] or [+0.450%; +1.190%]
  • ignore throughput [-4.442op/s; -1.658op/s] or [-1.137%; -0.424%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • ignore allocated_mem [-38 bytes; +46 bytes] or [-0.006%; +0.007%]
  • ignore execution_time [-128.316µs; -88.763µs] or [-6.500%; -4.496%]
  • 🟩 throughput [+25.566op/s; +36.291op/s] or [+5.047%; +7.164%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • ignore allocated_mem [-42 bytes; +23 bytes] or [-0.007%; +0.004%]
  • ignore execution_time [-155.201µs; -114.485µs] or [-3.936%; -2.903%]
  • ignore throughput [+7.863op/s; +10.446op/s] or [+3.101%; +4.119%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.001%; +0.008%]
  • 🟥 execution_time [+302.654ms; +303.750ms] or [+152.411%; +152.963%]
  • ignore throughput [+13255.051op/s; +14800.729op/s] or [+4.265%; +4.763%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+301.263ms; +302.498ms] or [+150.963%; +151.582%]
  • ignore throughput [+23031.504op/s; +28457.440op/s] or [+3.631%; +4.487%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+300.529ms; +303.732ms] or [+150.973%; +152.582%]
  • ignore throughput [+12977.684op/s; +21269.439op/s] or [+2.734%; +4.480%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.004%]
  • 🟥 execution_time [+301.894ms; +303.447ms] or [+151.601%; +152.381%]
  • ignore throughput [+3099.951op/s; +4652.068op/s] or [+1.039%; +1.559%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.006%]
  • 🟥 execution_time [+298.518ms; +300.097ms] or [+147.604%; +148.385%]
  • ignore throughput [+12035.268op/s; +16784.440op/s] or [+1.939%; +2.704%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+304.260ms; +307.926ms] or [+154.213%; +156.070%]
  • ignore throughput [-7528.545op/s; +1409.507op/s] or [-1.626%; +0.304%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • ignore allocated_mem [+0 bytes; +1 bytes] or [+0.108%; +0.119%]
  • 🟥 execution_time [+301.055ms; +302.831ms] or [+151.103%; +151.994%]
  • 🟥 throughput [-21514.212op/s; -19571.818op/s] or [-5.581%; -5.077%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.006%]
  • 🟥 execution_time [+300.368ms; +302.351ms] or [+149.706%; +150.694%]
  • 🟩 throughput [+52134.871op/s; +57291.742op/s] or [+10.352%; +11.376%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.006%]
  • 🟥 execution_time [+300.157ms; +302.593ms] or [+149.326%; +150.537%]
  • ignore throughput [-5778.404op/s; -626.126op/s] or [-1.368%; -0.148%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.006%]
  • ignore execution_time [-1430.714µs; -481.134µs] or [-0.711%; -0.239%]
  • ignore throughput [-9687.664op/s; -8638.562op/s] or [-3.896%; -3.474%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.003%]
  • 🟩 execution_time [-16.238ms; -11.561ms] or [-7.551%; -5.376%]
  • ignore throughput [+14786.556op/s; +23413.904op/s] or [+4.056%; +6.423%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.008%]
  • ignore execution_time [-0.275ms; +3.674ms] or [-0.138%; +1.843%]
  • ignore throughput [+1693.559op/s; +7603.161op/s] or [+0.618%; +2.775%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • ignore allocated_mem [-4.459KB; -4.431KB] or [-1.623%; -1.613%]
  • ignore execution_time [+1.986µs; +42.021µs] or [+0.490%; +10.379%]
  • ignore throughput [-221.921op/s; -19.317op/s] or [-8.930%; -0.777%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-20.960KB; -20.940KB] or [-7.646%; -7.638%]
  • unstable execution_time [-38.288µs; +14.434µs] or [-7.567%; +2.853%]
  • ignore throughput [-45.832op/s; +136.286op/s] or [-2.287%; +6.801%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-20.019KB; -20.003KB] or [-7.298%; -7.292%]
  • unstable execution_time [+0.793µs; +120.084µs] or [+0.137%; +20.810%]
  • unstable throughput [-125.722op/s; +76.888op/s] or [-7.183%; +4.393%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472

  • ignore allocated_mem [-2 bytes; +2 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [-58.117ns; +1402.784ns] or [-0.101%; +2.430%]
  • ignore throughput [-392.028op/s; +20.566op/s] or [-2.262%; +0.119%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • ignore allocated_mem [-4 bytes; +0 bytes] or [-0.010%; -0.001%]
  • 🟥 execution_time [+5.818µs; +9.794µs] or [+13.753%; +23.151%]
  • 🟥 throughput [-4501.725op/s; -2744.294op/s] or [-18.951%; -11.553%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +1 bytes] or [-0.002%; +0.002%]
  • unstable execution_time [-13.917µs; -6.795µs] or [-21.592%; -10.542%]
  • 🟩 throughput [+1716.767op/s; +3220.562op/s] or [+10.533%; +19.759%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • ignore allocated_mem [+1 bytes; +2 bytes] or [+0.039%; +0.050%]
  • 🟥 execution_time [+303.728ms; +305.332ms] or [+153.521%; +154.332%]
  • ignore throughput [-162.403op/s; -136.016op/s] or [-2.714%; -2.273%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • 🟥 execution_time [+302.201ms; +304.446ms] or [+153.819%; +154.962%]
  • ignore throughput [-179.237op/s; -104.566op/s] or [-2.223%; -1.297%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +0 bytes] or [-0.027%; -0.017%]
  • 🟥 execution_time [+299.223ms; +301.095ms] or [+149.798%; +150.735%]
  • ignore throughput [-214.978op/s; -152.687op/s] or [-2.739%; -1.945%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • ignore execution_time [-226.615µs; +349.870µs] or [-0.113%; +0.174%]
  • ignore throughput [-14344.353op/s; -12331.323op/s] or [-3.971%; -3.414%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.007%]
  • ignore execution_time [-672.356µs; -31.880µs] or [-0.336%; -0.016%]
  • 🟩 throughput [+52648.052op/s; +57610.189op/s] or [+9.965%; +10.904%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.006%]
  • ignore execution_time [+1.542ms; +5.287ms] or [+0.782%; +2.680%]
  • ignore throughput [-3403.449op/s; +5109.947op/s] or [-0.805%; +1.209%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • 🟥 execution_time [+300.548ms; +302.330ms] or [+149.796%; +150.684%]
  • ignore throughput [-1122.209op/s; -142.353op/s] or [-0.741%; -0.094%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+0.000%; +0.009%]
  • 🟥 execution_time [+302.010ms; +303.384ms] or [+151.655%; +152.345%]
  • ignore throughput [+3435.085op/s; +5487.334op/s] or [+1.494%; +2.386%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.003%]
  • 🟥 execution_time [+303.784ms; +306.153ms] or [+154.060%; +155.261%]
  • ignore throughput [-365.624op/s; +1473.809op/s] or [-0.206%; +0.830%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.541ms; +300.312ms] or [+149.413%; +149.797%]
  • 🟩 throughput [+66038610.329op/s; +66315153.196op/s] or [+48.093%; +48.295%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • ignore allocated_mem [+86 bytes; +88 bytes] or [+0.504%; +0.514%]
  • unstable execution_time [+384.471ms; +415.207ms] or [+478.158%; +516.384%]
  • 🟩 throughput [+941.671op/s; +1112.555op/s] or [+7.280%; +8.601%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.427ms; +300.337ms] or [+149.347%; +149.801%]
  • ignore throughput [+1669181.820op/s; +2608058.849op/s] or [+0.739%; +1.155%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [+262.822µs; +734.845µs] or [+0.131%; +0.368%]
  • ignore throughput [+9715.627op/s; +13115.402op/s] or [+1.084%; +1.464%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.007%]
  • ignore execution_time [-5.162ms; -3.997ms] or [-2.528%; -1.958%]
  • 🟩 throughput [+91988.604op/s; +104359.939op/s] or [+8.589%; +9.744%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.006%]
  • ignore execution_time [-0.645ms; +3.461ms] or [-0.327%; +1.751%]
  • 🟩 throughput [+46830.276op/s; +66483.359op/s] or [+5.421%; +7.695%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.000%; +0.009%]
  • ignore execution_time [+473.566µs; +961.355µs] or [+0.237%; +0.480%]
  • ignore throughput [-2559.884op/s; +3291.140op/s] or [-0.234%; +0.301%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.004%]
  • ignore execution_time [+5.966ms; +10.064ms] or [+3.108%; +5.243%]
  • 🟩 throughput [+85487.718op/s; +114981.319op/s] or [+6.617%; +8.900%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.001%; +0.008%]
  • ignore execution_time [-5.710ms; -4.178ms] or [-2.805%; -2.053%]
  • 🟩 throughput [+66744.111op/s; +74877.952op/s] or [+6.629%; +7.437%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.002%]
  • ignore execution_time [-1.854ms; -0.453ms] or [-0.923%; -0.226%]
  • ignore throughput [+9828.177op/s; +12996.681op/s] or [+2.190%; +2.896%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • ignore execution_time [-507.934µs; +986.066µs] or [-0.254%; +0.492%]
  • 🟩 throughput [+53744.500op/s; +58687.391op/s] or [+9.759%; +10.657%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • ignore execution_time [-1414.737µs; +2669.995µs] or [-0.711%; +1.342%]
  • ignore throughput [+18875.638op/s; +28612.021op/s] or [+4.225%; +6.404%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [-969.474µs; +9.650µs] or [-0.483%; +0.005%]
  • ignore throughput [-11560.099op/s; -7771.643op/s] or [-1.692%; -1.137%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.007%]
  • ignore execution_time [-0.722ms; +2.871ms] or [-0.361%; +1.436%]
  • 🟩 throughput [+54227.634op/s; +72831.301op/s] or [+6.059%; +8.137%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • ignore execution_time [+1.013ms; +4.899ms] or [+0.515%; +2.488%]
  • ignore throughput [+21997.044op/s; +36795.667op/s] or [+3.071%; +5.138%]

@dd-trace-dotnet-ci-bot
Copy link
Copy Markdown

dd-trace-dotnet-ci-bot Bot commented Apr 17, 2026 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8478) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.49 ± (72.42 - 72.77) ms72.95 ± (72.82 - 73.18) ms+0.6%✅⬆️
.NET Framework 4.8 - Bailout
duration79.54 ± (79.41 - 79.97) ms79.55 ± (79.40 - 80.06) ms+0.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1081.69 ± (1084.58 - 1094.14) ms1079.10 ± (1079.57 - 1085.81) ms-0.2%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.62 ± (22.56 - 22.68) ms22.67 ± (22.60 - 22.73) ms+0.2%✅⬆️
process.time_to_main_ms85.58 ± (85.24 - 85.92) ms85.95 ± (85.58 - 86.32) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.84 ± (10.84 - 10.85) MB10.92 ± (10.91 - 10.92) MB+0.7%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.63 ± (22.58 - 22.69) ms22.67 ± (22.62 - 22.73) ms+0.2%✅⬆️
process.time_to_main_ms87.60 ± (87.29 - 87.91) ms88.49 ± (88.19 - 88.80) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.93 - 10.94) MB10.93 ± (10.93 - 10.94) MB-0.0%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms231.02 ± (229.85 - 232.19) ms231.68 ± (230.56 - 232.79) ms+0.3%✅⬆️
process.time_to_main_ms532.28 ± (530.84 - 533.72) ms530.81 ± (529.30 - 532.32) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.54 ± (48.52 - 48.56) MB48.55 ± (48.53 - 48.58) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms21.17 ± (21.13 - 21.21) ms21.27 ± (21.23 - 21.31) ms+0.5%✅⬆️
process.time_to_main_ms73.00 ± (72.84 - 73.17) ms73.10 ± (72.92 - 73.28) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.62 ± (10.61 - 10.62) MB10.62 ± (10.62 - 10.63) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.45 ± (21.40 - 21.51) ms21.69 ± (21.63 - 21.75) ms+1.1%✅⬆️
process.time_to_main_ms77.40 ± (77.10 - 77.69) ms77.65 ± (77.38 - 77.92) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.73 ± (10.73 - 10.73) MB10.75 ± (10.75 - 10.75) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms384.97 ± (383.15 - 386.80) ms386.63 ± (384.38 - 388.89) ms+0.4%✅⬆️
process.time_to_main_ms527.95 ± (526.70 - 529.20) ms529.68 ± (528.37 - 530.99) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.04 ± (50.02 - 50.07) MB50.07 ± (50.05 - 50.10) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (28 - 29)28 ± (28 - 28)-0.2%✅
.NET 8 - Baseline
process.internal_duration_ms19.61 ± (19.57 - 19.65) ms19.55 ± (19.52 - 19.59) ms-0.3%✅
process.time_to_main_ms73.36 ± (73.21 - 73.51) ms72.98 ± (72.82 - 73.13) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.66 ± (7.66 - 7.67) MB7.66 ± (7.66 - 7.67) MB-0.0%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.52 ± (19.48 - 19.57) ms19.54 ± (19.50 - 19.58) ms+0.1%✅⬆️
process.time_to_main_ms74.23 ± (74.05 - 74.40) ms74.09 ± (73.93 - 74.24) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.71 - 7.72) MB7.72 ± (7.71 - 7.72) MB+0.0%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms305.13 ± (302.79 - 307.47) ms305.38 ± (302.80 - 307.96) ms+0.1%✅⬆️
process.time_to_main_ms492.73 ± (491.60 - 493.87) ms495.73 ± (494.31 - 497.16) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed37.32 ± (37.27 - 37.37) MB37.16 ± (37.11 - 37.21) MB-0.4%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.7%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration219.10 ± (219.41 - 222.65) ms208.16 ± (208.28 - 209.67) ms-5.0%✅
.NET Framework 4.8 - Bailout
duration223.36 ± (223.98 - 227.29) ms213.05 ± (213.32 - 214.62) ms-4.6%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1292.23 ± (1288.50 - 1297.72) ms1223.80 ± (1223.24 - 1230.01) ms-5.3%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms215.22 ± (213.77 - 216.68) ms203.71 ± (203.05 - 204.37) ms-5.3%✅
process.time_to_main_ms94.30 ± (93.58 - 95.02) ms88.51 ± (88.19 - 88.84) ms-6.1%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed15.81 ± (15.80 - 15.83) MB15.95 ± (15.93 - 15.96) MB+0.8%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.4%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms214.01 ± (212.67 - 215.35) ms202.04 ± (201.42 - 202.66) ms-5.6%✅
process.time_to_main_ms94.79 ± (94.09 - 95.48) ms89.68 ± (89.34 - 90.02) ms-5.4%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed15.91 ± (15.89 - 15.93) MB16.02 ± (16.00 - 16.03) MB+0.7%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.7%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms424.65 ± (422.61 - 426.69) ms410.34 ± (409.01 - 411.68) ms-3.4%✅
process.time_to_main_ms566.19 ± (564.09 - 568.29) ms549.36 ± (547.85 - 550.88) ms-3.0%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed59.30 ± (59.23 - 59.36) MB59.31 ± (59.27 - 59.36) MB+0.0%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.3%✅
.NET 6 - Baseline
process.internal_duration_ms215.02 ± (213.77 - 216.26) ms207.09 ± (206.33 - 207.85) ms-3.7%✅
process.time_to_main_ms79.57 ± (78.99 - 80.16) ms76.63 ± (76.30 - 76.96) ms-3.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.15 ± (16.13 - 16.17) MB16.25 ± (16.23 - 16.27) MB+0.6%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)19 ± (19 - 19)-0.8%✅
.NET 6 - Bailout
process.internal_duration_ms215.17 ± (213.76 - 216.59) ms207.17 ± (206.37 - 207.97) ms-3.7%✅
process.time_to_main_ms81.33 ± (80.76 - 81.89) ms78.18 ± (77.86 - 78.49) ms-3.9%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.19 ± (16.17 - 16.21) MB16.27 ± (16.25 - 16.28) MB+0.4%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)20 ± (20 - 21)-0.3%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms604.45 ± (600.83 - 608.07) ms602.19 ± (599.48 - 604.90) ms-0.4%✅
process.time_to_main_ms562.03 ± (560.32 - 563.75) ms546.94 ± (545.55 - 548.33) ms-2.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.51 ± (61.41 - 61.61) MB61.63 ± (61.54 - 61.73) MB+0.2%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-1.0%✅
.NET 8 - Baseline
process.internal_duration_ms208.96 ± (207.79 - 210.14) ms206.62 ± (205.80 - 207.43) ms-1.1%✅
process.time_to_main_ms77.04 ± (76.58 - 77.51) ms76.24 ± (75.90 - 76.58) ms-1.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.52 ± (11.50 - 11.54) MB11.51 ± (11.49 - 11.52) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.0%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms210.85 ± (209.67 - 212.03) ms205.84 ± (205.04 - 206.64) ms-2.4%✅
process.time_to_main_ms78.64 ± (78.21 - 79.07) ms77.23 ± (76.92 - 77.55) ms-1.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.53 ± (11.52 - 11.55) MB11.62 ± (11.61 - 11.64) MB+0.8%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.3%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms580.52 ± (571.87 - 589.17) ms556.95 ± (549.39 - 564.52) ms-4.1%✅
process.time_to_main_ms519.15 ± (517.01 - 521.28) ms505.94 ± (504.54 - 507.34) ms-2.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed51.29 ± (51.20 - 51.38) MB51.02 ± (50.92 - 51.12) MB-0.5%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.1%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8478) - mean (73ms)  : 70, 76
    master - mean (73ms)  : 70, 75

    section Bailout
    This PR (8478) - mean (80ms)  : 75, 85
    master - mean (80ms)  : 76, 84

    section CallTarget+Inlining+NGEN
    This PR (8478) - mean (1,083ms)  : 1037, 1128
    master - mean (1,089ms)  : 1017, 1162
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8478) - mean (116ms)  : 108, 124
    master - mean (115ms)  : 109, 122

    section Bailout
    This PR (8478) - mean (118ms)  : 111, 125
    master - mean (117ms)  : 112, 123

    section CallTarget+Inlining+NGEN
    This PR (8478) - mean (800ms)  : 777, 824
    master - mean (801ms)  : 776, 825
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8478) - mean (101ms)  : 98, 104
    master - mean (101ms)  : 96, 105

    section Bailout
    This PR (8478) - mean (106ms)  : 101, 111
    master - mean (106ms)  : 99, 112

    section CallTarget+Inlining+NGEN
    This PR (8478) - mean (945ms)  : 909, 982
    master - mean (942ms)  : 910, 974
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8478) - mean (100ms)  : 97, 104
    master - mean (101ms)  : 98, 104

    section Bailout
    This PR (8478) - mean (101ms)  : 99, 104
    master - mean (102ms)  : 99, 104

    section CallTarget+Inlining+NGEN
    This PR (8478) - mean (832ms)  : 785, 878
    master - mean (830ms)  : 789, 870
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8478) - mean (209ms)  : 198, 220
    master - mean (221ms)  : 196, 246

    section Bailout
    This PR (8478) - mean (214ms)  : 205, 223
    master - mean (226ms)  : 200, 251

    section CallTarget+Inlining+NGEN
    This PR (8478) - mean (1,227ms)  : 1178, 1275
    master - mean (1,293ms)  : 1225, 1361
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8478) - mean (302ms)  : 286, 317
    master - mean (322ms)  : 287, 357

    section Bailout
    This PR (8478) - mean (302ms)  : 287, 317
    master - mean (322ms)  : 289, 354

    section CallTarget+Inlining+NGEN
    This PR (8478) - mean (999ms)  : 969, 1028
    master - mean (1,038ms)  : 1001, 1075
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8478) - mean (294ms)  : 278, 309
    master - mean (306ms)  : 278, 335

    section Bailout
    This PR (8478) - mean (296ms)  : 278, 314
    master - mean (308ms)  : 276, 340

    section CallTarget+Inlining+NGEN
    This PR (8478) - mean (1,180ms)  : 1134, 1226
    master - mean (1,205ms)  : 1131, 1278
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8478) - mean (296ms)  : 276, 315
    master - mean (299ms)  : 274, 323

    section Bailout
    This PR (8478) - mean (295ms)  : 277, 312
    master - mean (304ms)  : 275, 333

    section CallTarget+Inlining+NGEN
    This PR (8478) - mean (1,096ms)  : 988, 1205
    master - mean (1,134ms)  : 1017, 1252
Loading

@bouwkast bouwkast force-pushed the steven/cooldown-fix branch from d41ac11 to 3d9a18e Compare April 20, 2026 18:39
@bouwkast bouwkast marked this pull request as ready for review April 21, 2026 12:59
@bouwkast bouwkast requested a review from a team as a code owner April 21, 2026 12:59
andrewlock
andrewlock approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

Comment thread tracer/build/_build/GeneratePackageVersions/PackageVersionGenerator.cs Outdated
Comment thread tracer/build/_build/GeneratePackageVersions/PackageVersionGenerator.cs Outdated
Comment on lines +217 to +220
/// Returns the highest previously-tested version for the given entry, restricted to its
/// [MinVersion, MaxVersionExclusive) range. The range restriction matters for split-range
/// packages (e.g. GraphQL 4.x-6.x and 7.x-9.x): a high max from the 7.x-9.x entry must not
/// suppress cooldown checks on the 4.x-6.x entry.
Copy link
Copy Markdown
Member

@andrewlock andrewlock Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something still doesn't feel quite right here to me, as I think we should really probably be keyed on major version, as opposed to "range", but 1. Maybe that already works 2. That's a super edge case, 3. meh 😄

Copy link
Copy Markdown
Collaborator Author

@bouwkast bouwkast Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified this a bit more, probably needs a bit more work

Comment thread tracer/build/_build/GeneratePackageVersions/PackageVersionGenerator.cs Outdated
Comment thread tracer/build/nuget_version_cache.json Outdated
Copy link
Copy Markdown
Member

@andrewlock andrewlock Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Image

@andrewlock andrewlock mentioned this pull request Apr 22, 2026
Merged
@bouwkast bouwkast merged commit 0f47fd3 into master Apr 22, 2026
138 checks passed
@bouwkast bouwkast deleted the steven/cooldown-fix branch April 22, 2026 17:40
@github-actions github-actions Bot added this to the vNext-v3 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

2 participants

@bouwkast @andrewlock