Update TagListGenerator to always useReadOnlySpan<byte> properties#8486
Update TagListGenerator to always useReadOnlySpan<byte> properties#8486andrewlock wants to merge 2 commits intoandrew/use-new-span-tfrom
TagListGenerator to always useReadOnlySpan<byte> properties#8486Conversation
25f6d5e to
b1f8279
Compare
eca7df4 to
54730c9
Compare
BenchmarksBenchmark execution time: 2026-04-21 11:24:15 Comparing candidate commit 54730c9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
Summary of changes
Update the tag list generator to always use
ReadOnlySpan<byte>properties instead ofbyte[]Reason for change
After moving our vendored
Span<T>implementation into theSystemnamespace, various optimizations open up to us, including usingReadOnlySpan<byte>properties on .NET Framework instead ofstatic readonly byte[]to avoid startup costs.Implementation details
Replace the code generated by the generator, and update the generated code
Test coverage
Covered by snapshot tests and behaviour is covered by existing tests. We'll check the benchmarks to make sure that we don't see any perf impact (there shouldn't be, impact should just be reduced startup costs)
Other details
Depends on a stack updating our vendored system code
ReadOnlySpan<T>,Span<T>et. al. to System namespace #8476Span<T>namespace changes #8477