Skip SubmitsOtlpLogs and SubmitsOtlpMetrics#8488
Merged
andrewlock merged 1 commit intomasterfrom Apr 21, 2026
Merged
Conversation
bouwkast
commented
Apr 20, 2026
|
|
||
| #if NET6_0_OR_GREATER | ||
| [SkippableTheory] | ||
| [Trait("SkipInCI", "True")] |
Collaborator
Author
There was a problem hiding this comment.
However, SubmitsOtlpLogs has come up as well and appears to be a set of similar issues.
Attempting to fix both here Fix OTLP HTTP/protobuf export failures and improve OTLP integration test reliability
link04
approved these changes
Apr 20, 2026
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8488) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8488) - mean (73ms) : 70, 77
master - mean (73ms) : 69, 77
section Bailout
This PR (8488) - mean (80ms) : 75, 84
master - mean (77ms) : 74, 80
section CallTarget+Inlining+NGEN
This PR (8488) - mean (1,088ms) : 1025, 1151
master - mean (1,083ms) : 1033, 1133
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8488) - mean (117ms) : 111, 124
master - mean (114ms) : 109, 120
section Bailout
This PR (8488) - mean (116ms) : 111, 121
master - mean (114ms) : 111, 117
section CallTarget+Inlining+NGEN
This PR (8488) - mean (797ms) : 769, 825
master - mean (803ms) : 773, 834
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8488) - mean (101ms) : 98, 104
master - mean (102ms) : 97, 107
section Bailout
This PR (8488) - mean (106ms) : 100, 112
master - mean (104ms) : 98, 110
section CallTarget+Inlining+NGEN
This PR (8488) - mean (946ms) : 917, 975
master - mean (942ms) : 910, 974
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8488) - mean (104ms) : 98, 110
master - mean (99ms) : 96, 102
section Bailout
This PR (8488) - mean (102ms) : 99, 106
master - mean (102ms) : 97, 106
section CallTarget+Inlining+NGEN
This PR (8488) - mean (825ms) : 784, 866
master - mean (831ms) : 786, 875
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8488) - mean (192ms) : 184, 199
master - mean (193ms) : 190, 196
section Bailout
This PR (8488) - mean (195ms) : 193, 197
master - mean (196ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (8488) - mean (1,149ms) : 1110, 1189
master - mean (1,163ms) : 1109, 1217
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8488) - mean (274ms) : 270, 278
master - mean (277ms) : 269, 285
section Bailout
This PR (8488) - mean (274ms) : 271, 277
master - mean (277ms) : 274, 280
section CallTarget+Inlining+NGEN
This PR (8488) - mean (928ms) : 903, 954
master - mean (929ms) : 908, 951
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8488) - mean (269ms) : 264, 274
master - mean (270ms) : 266, 274
section Bailout
This PR (8488) - mean (268ms) : 265, 271
master - mean (270ms) : 267, 274
section CallTarget+Inlining+NGEN
This PR (8488) - mean (1,140ms) : 1102, 1179
master - mean (1,141ms) : 1097, 1185
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8488) - mean (266ms) : 263, 269
master - mean (268ms) : 263, 272
section Bailout
This PR (8488) - mean (267ms) : 264, 270
master - mean (269ms) : 264, 273
section CallTarget+Inlining+NGEN
This PR (8488) - mean (1,024ms) : 979, 1069
master - mean (1,021ms) : 985, 1056
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-04-20 21:13:12 Comparing candidate commit ee903eb in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 25 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Skips
SubmitsOtlpLogsandSubmitsOtlpMetricsas both have been significantly more flaky recently and in some PRs (unrelated to them) have been constantly failing and blocking builds.Reason for change
Skips
SubmitsOtlpLogsandSubmitsOtlpMetricsas both have been significantly more flaky recently and in some PRs (unrelated to them) have been constantly failing and blocking builds.Implementation details
Marked as Skip
Test coverage
Less
Other details
I have been making progress, but haven't resolved this here Fix OTLP HTTP/protobuf export failures and improve OTLP integration test reliability, but I haven't reproduced it locally AND it seems to be getting significantly worse recently - one theory is that our agents are under much higher load which is causing them to hit this.